test(element): migrate element-ng to vitest part 2#1700
Merged
spike-rabbit merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request continues the migration of tests from Karma/Jasmine to Vitest for the element-ng project, focusing on components in directories starting with 'd'. The changes correctly update test configurations, replace Jasmine APIs with their Vitest counterparts, and refactor some test logic for stability. The file structure is also improved by moving a test helper. The migration is well-executed, but I have one suggestion to improve test code maintainability by addressing a redundant change detection call.
spliffone
force-pushed
the
test/migrate-vitest-part2
branch
2 times, most recently
from
42ec329 to
5adb6f2
Compare
spike-rabbit
requested changes
Mar 20, 2026
Member
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
Please double check all new fixture.detectChanges / fixture.whenStable.
I prefer new signals for components instead.
projects/element-ng/datepicker/components/si-day-selection.component.spec.ts
Show resolved
Hide resolved
projects/element-ng/date-range-filter/si-date-range-filter.component.spec.ts
Show resolved
Hide resolved
projects/element-ng/date-range-filter/si-date-range-filter.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/element-ng/datepicker/components/si-day-selection.component.spec.ts
Show resolved
Hide resolved
spliffone
force-pushed
the
test/migrate-vitest-part2
branch
3 times, most recently
from
a493714 to
71466db
Compare
spliffone
force-pushed
the
test/migrate-vitest-part2
branch
from
71466db to
2600250
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: