Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
The pull request introduces a new whitespace trimming mechanism for filtered search inputs, triggered when a search input or criterion value loses focus. This involves adding new blur output events across si-filtered-search-typeahead, si-filtered-search-value, and si-filtered-search components, and implementing a trimWhitespaces method to clean up both the main search value and individual criterion values. Additionally, the tracking strategy for criteria in the si-filtered-search component's template was updated, and a test expectation was adjusted. A review comment suggests removing commented-out code in si-filtered-search.component.ts to improve code cleanliness.
projects/element-ng/filtered-search/si-filtered-search.component.ts
Outdated
Show resolved
Hide resolved
ac8402b to
aa4bb89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1228
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: