Skip to content

fix(filtered-search): trim whitespaces#1705

Open
robertwilde wants to merge 1 commit intomainfrom
fix/filtered-search/tw-2
Open

fix(filtered-search): trim whitespaces#1705
robertwilde wants to merge 1 commit intomainfrom
fix/filtered-search/tw-2

Conversation

@robertwilde
Copy link
Collaborator

@robertwilde robertwilde commented Mar 20, 2026

Closes #1228

  • add function to trim whitespaces that gets called on blur events
  • add new custom blur event to make sure whitespaces are trimmed when user clicks outside of criterion

Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a new whitespace trimming mechanism for filtered search inputs, triggered when a search input or criterion value loses focus. This involves adding new blur output events across si-filtered-search-typeahead, si-filtered-search-value, and si-filtered-search components, and implementing a trimWhitespaces method to clean up both the main search value and individual criterion values. Additionally, the tracking strategy for criteria in the si-filtered-search component's template was updated, and a test expectation was adjusted. A review comment suggests removing commented-out code in si-filtered-search.component.ts to improve code cleanliness.

@robertwilde robertwilde force-pushed the fix/filtered-search/tw-2 branch from ac8402b to aa4bb89 Compare March 20, 2026 17:06
@robertwilde robertwilde marked this pull request as ready for review March 20, 2026 17:22
@robertwilde robertwilde requested review from a team as code owners March 20, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

filtered-search: trim white space

2 participants