Draft
Conversation
spike-rabbit
force-pushed
the
test/element/t-vitest
branch
from
e4408e5 to
6287568
Compare
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
spike-rabbit
force-pushed
the
test/element/t-vitest
branch
2 times, most recently
from
34442a3 to
5ff284c
Compare
spike-rabbit
force-pushed
the
test/element/t-vitest
branch
from
5ff284c to
bc917b8
Compare
spliffone
reviewed
Mar 21, 2026
Comment on lines
+241
to
+248
| vi.advanceTimersByTime(500); | ||
| await fixture.whenStable(); | ||
| focusNext(); | ||
| jasmine.clock().tick(500); | ||
| vi.advanceTimersByTime(500); | ||
| await fixture.whenStable(); | ||
| expect(document.activeElement).toBe(getElement(1).nativeElement); | ||
| (document.activeElement! as HTMLElement).blur(); | ||
| jasmine.clock().tick(500); | ||
| vi.advanceTimersByTime(500); |
Member
There was a problem hiding this comment.
I guess the timer aren'T necessary:
Suggested change
| vi.advanceTimersByTime(500); | |
| await fixture.whenStable(); | |
| focusNext(); | |
| jasmine.clock().tick(500); | |
| vi.advanceTimersByTime(500); | |
| await fixture.whenStable(); | |
| expect(document.activeElement).toBe(getElement(1).nativeElement); | |
| (document.activeElement! as HTMLElement).blur(); | |
| jasmine.clock().tick(500); | |
| vi.advanceTimersByTime(500); | |
| await fixture.whenStable(); | |
| focusNext(); | |
| await fixture.whenStable(); | |
| expect(document.activeElement).toBe(getElement(1).nativeElement); | |
| (document.activeElement! as HTMLElement).blur(); | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: