refactor(main-detail-container): migrate to host binding and takeUnti…#1711
Open
refactor(main-detail-container): migrate to host binding and takeUnti…#1711
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a solid refactoring of the SiMainDetailContainerComponent. It correctly migrates to using the host property instead of @HostBinding and adopts takeUntilDestroyed for safer subscription management, aligning with modern Angular practices and your style guide. I've added a couple of suggestions to further improve the implementation by simplifying the use of takeUntilDestroyed and replacing a setTimeout with a more robust RxJS timer to prevent potential issues on component destruction.
projects/element-ng/main-detail-container/si-main-detail-container.component.ts
Show resolved
Hide resolved
projects/element-ng/main-detail-container/si-main-detail-container.component.ts
Outdated
Show resolved
Hide resolved
spliffone
force-pushed
the
refactor/minor-main-detail-improvements
branch
from
7a8d99e to
2fb0d8d
Compare
spliffone
force-pushed
the
refactor/minor-main-detail-improvements
branch
from
2fb0d8d to
74f204e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lDestroyed
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: