Update Fuse Client-Daemon linger timeout logic#1741
Draft
Nathan Graybeal (ngraybeal) wants to merge 2 commits into
Draft
Update Fuse Client-Daemon linger timeout logic#1741Nathan Graybeal (ngraybeal) wants to merge 2 commits into
Nathan Graybeal (ngraybeal) wants to merge 2 commits into
Conversation
This inverts the calculation of linger timeout from the retry wait_ms. Instead, the linger timeout is now a constant with a max wait_ms being calculated from that. Each retry will increase its wait up to the max.
Nathan Graybeal (ngraybeal)
requested review from
Abrar Quazi (AbrarQuazi),
Sam May (ag-eitilt) and
Will Dietz (dtzSiFive)
Collaborator
Author
|
This is failing b/c the new linger timeout exceeds that of the wake runtime, so the daemon is still alive and mounted when we began tearing down the workspace. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This inverts the calculation of linger timeout from the retry wait_ms. Instead, the linger timeout is now a constant with a max wait_ms being calculated from that. Each retry will increase its wait up to the max.
The default linger timeout was increased to 60 seconds.
I thought about exposing
linger_timeout_secsup to wake runtime config, but it didn't seem straightforward at this time.