wake: implement --prune feature.#1858
Open
Will Dietz (dtzSiFive) wants to merge 1 commit into
Open
Conversation
Will Dietz (dtzSiFive)
requested review from
Abrar Quazi (AbrarQuazi) and
Sam May (ag-eitilt)
| const char *sql_get_job_output_paths = | ||
| "select distinct f.file_id, f.path, f.type" | ||
| " from filetree ft join files f on f.file_id=ft.file_id join jobs j on ft.job_id=j.job_id" | ||
| " where ft.access = 2" |
Contributor
Author
There was a problem hiding this comment.
Consideration:
Drop this qualifier (and rename to get_job_paths or whatever).
And actually simplify this all the way down to just:
select distinct f.file_id, f.path, f.type .
Everything is someone's output.
Anyway hopefully this is easy enough to shape however we'd like.
Contributor
Author
There was a problem hiding this comment.
I think that's the right call so went ahead and made the change.
Checks for existance and file type. Add basic test.
Will Dietz (dtzSiFive)
force-pushed
the
feature/prune
branch
from
63f0408 to
c3fc807
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks for existance and file type.
Add basic test.