Update RSC to be mw/CAS compliant and fix filetype collision issue#1859
Open
Abrar Quazi (AbrarQuazi) wants to merge 1 commit into
Open
Update RSC to be mw/CAS compliant and fix filetype collision issue#1859Abrar Quazi (AbrarQuazi) wants to merge 1 commit into
Abrar Quazi (AbrarQuazi) wants to merge 1 commit into
Conversation
Contributor
Abrar Quazi (AbrarQuazi)
commented
May 20, 2026
Abrar Quazi (AbrarQuazi)
commented
- Make RSC client upload from CAS
- Make RSC client download to staging, and ingest + materialize into/from CAS
- Fix filetype collision issue in RSC (add filetype and mode to job reuse key)
- Add hash to output symlink target string so RSC client doesn't need to recompute it
Abrar Quazi (AbrarQuazi)
requested review from
Sam May (ag-eitilt) and
Nathan Graybeal (ngraybeal)
| // as before, preserving their cache. New-client keys mix in type+mode and | ||
| // land in a disjoint namespace, fixing the symlink-vs-file collision. | ||
| // | ||
| // TODO: Remove this check once all clients have been migrated to the newer version. |
Collaborator
There was a problem hiding this comment.
Should be tracking these in a more central location so we can give some EOL timeline?
| let chunked: Vec<Vec<output_file::ActiveModel>> = output_files | ||
| .into_iter() | ||
| .chunks((MAX_SQLX_PARAMS / 6).into()) | ||
| .chunks((MAX_SQLX_PARAMS / 7).into()) |
Collaborator
There was a problem hiding this comment.
Magic number. Should we assign this to a var for clarity?
|
|
||
| require Pass _ = verifyBlobHash blobId actualHash contentHash | ||
|
|
||
| def fixupScript = |
Collaborator
There was a problem hiding this comment.
Happy to see go away for multiple reasons. 😄
Nathan Graybeal (ngraybeal)
approved these changes
May 22, 2026
Collaborator
Nathan Graybeal (ngraybeal)
left a comment
Nathan Graybeal (ngraybeal)
left a comment
There was a problem hiding this comment.
Happy to see what a CAS system starts affording us.
|
|
||
| # Returns the absolute CAS filesystem path for the blob with the given content hash. | ||
| # Fails if the blob is not present in the local CAS store. | ||
| export def primCasBlobPath (hash: String): Result String Error = |
Collaborator
There was a problem hiding this comment.
NIT: Path in the function name, but returns a String.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.