Skip to content

Remove artifacts created in the course of testing#1862

Open
Sam May (ag-eitilt) wants to merge 1 commit into
masterfrom
clean-test-artifacts
Open

Remove artifacts created in the course of testing#1862
Sam May (ag-eitilt) wants to merge 1 commit into
masterfrom
clean-test-artifacts

Conversation

@ag-eitilt
Copy link
Copy Markdown
Collaborator

A number of our tests create files to test visibility, collisions, etc. These have been sticking around after the test is complete and cluttering git status. This PR adds cleanup rms at the end of the relevant tests so that the workspace is left in the same state it started.

Two notes on the implementation:

  • None of these files should be critical for debugging errors, if we do wind up regressing one or more of these tests. (If they were, the better solution would be adding them to .gitignore -- as we do for the wake.db and similar which are kept around.)
  • We still want to keep the removals of these same files at the beginning of the scripts, in case one of them gets interrupted halfway through and needs cleanup before the next run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant