Remove artifacts created in the course of testing#1862
Open
Sam May (ag-eitilt) wants to merge 1 commit into
Open
Remove artifacts created in the course of testing#1862Sam May (ag-eitilt) wants to merge 1 commit into
Sam May (ag-eitilt) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of our tests create files to test visibility, collisions, etc. These have been sticking around after the test is complete and cluttering
git status. This PR adds cleanuprms at the end of the relevant tests so that the workspace is left in the same state it started.Two notes on the implementation:
.gitignore-- as we do for thewake.dband similar which are kept around.)