Skip to content

Prevent entering oversized custom donation amounts#14854

Open
abgolor wants to merge 1 commit into
signalapp:mainfrom
abgolor:fix-custom-donation-max-input
Open

Prevent entering oversized custom donation amounts#14854
abgolor wants to merge 1 commit into
signalapp:mainfrom
abgolor:fix-custom-donation-max-input

Conversation

@abgolor

@abgolor abgolor commented Jun 26, 2026

Copy link
Copy Markdown

First time contributor checklist

Contributor checklist

  • I am following the Code Style Guidelines
  • I have tested my contribution on these devices:
    • Google Pixel 8, Android 16 (Build: BP3A.251005.004.B2)
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Fixes #14750

Summary

This change adds input-level validation to the custom one-time donation amount field.

Previously, users could continue entering arbitrarily large numeric values into the custom donation amount field. This change prevents additional digits from being entered once the configured input limit has been reached while preserving the existing currency formatting and validation behavior.

Testing

Device

  • Google Pixel 8
  • Android 16 (Build: BP3A.251005.004.B2)

App

  • Signal Android 8.17.1 (versionCode 171101)

Verified that:

  • Valid custom donation amounts can still be entered.
  • Currency formatting continues to work correctly.
  • Additional digits are rejected once the configured input limit is reached.
  • Existing predefined donation options continue to function as expected.

Screenshots

Before

Before

After

After

@abgolor

abgolor commented Jun 30, 2026

Copy link
Copy Markdown
Author

@jeffrey-signal @cody-signal I solved this issue but I am yet to get any feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Donation] Custom amount field accepts unrealistically large values — no input validation

1 participant