Collapse messages with excessive newlines regardless of character count#14863
Open
Vishvendra47 wants to merge 1 commit into
Open
Collapse messages with excessive newlines regardless of character count#14863Vishvendra47 wants to merge 1 commit into
Vishvendra47 wants to merge 1 commit into
Conversation
Previously, whether a message needed a 'Read more' overflow was decided purely by character count (MAX_BODY_DISPLAY_LENGTH). Messages with very few characters but a large number of newlines were never flagged as overflowing, causing them to render at full height and degrade scroll performance. This adds a line-count check (MAX_BODY_DISPLAY_LINES) alongside the existing character-count check in hasExtraText(), and introduces getMaxBodyDisplayLength() to compute the correct truncation point based on whichever limit (chars or lines) is hit first. Fixes signalapp#14861
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription
Previously, whether a message needed a "Read more" overflow was decided purely by character count (
MAX_BODY_DISPLAY_LENGTH). Messages with very few characters but a large number of newlines were never flagged as overflowing, causing them to render at full height and degrade scroll performance (see #14861).This adds a line-count check (
MAX_BODY_DISPLAY_LINES) alongside the existing character-count check inhasExtraText(), and introducesgetMaxBodyDisplayLength()to compute the correct truncation point based on whichever limit (characters or lines) is hit first.How I tested it:
Fixes #14861