Preserve bubbles when cancelling notifications.#14889
Open
scueZ wants to merge 1 commit into
Open
Conversation
Cancelling a notification also dismisses its bubble. Collapsed bubble notifications are now re-posted with suppression instead, which clears the shade and badge while keeping the bubble. Bubble notifications report as not cancelled so the group summary, whose cancellation can take its bubbled children down with it, is kept alive. Fixes signalapp#14699
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #1234syntaxDescription
Fixes #14699.
When Signal cancels message notifications — for example after messages are read on a linked device —
NotificationManager.cancel()also dismisses any bubble attached to the notification. For users who keep conversations bubbled, reading on another device therefore destroys their bubbles, whereas the system's swipe-dismiss gesture hides the notification but keeps the bubble.This change re-posts collapsed bubble notifications with
BubbleMetadata.setSuppressNotification(true)instead of cancelling them: the notification leaves the shade and the badge is cleared, while the bubble is preserved — matching the platform's swipe-dismiss behavior.FLAG_BUBBLEnot set) are cancelled outright as before.Tested on a Samsung Galaxy S23 (Android 15): collapsed bubbles (1:1 and group) survive cross-device read with the shade entry and badge cleared; expanded bubbles, fullscreen conversations, and non-bubbled notifications behave as before.