This repository was archived by the owner on Feb 12, 2022. It is now read-only.
Updates project versions, minor build fixes#4
Open
dannypurcell wants to merge 1 commit intosignalapp:masterfrom
Open
Updates project versions, minor build fixes#4dannypurcell wants to merge 1 commit intosignalapp:masterfrom
dannypurcell wants to merge 1 commit intosignalapp:masterfrom
Conversation
|
👍 Can this get merged, please? |
|
I require to add GPG skip in order to build success org.apache.maven.plugins maven-gpg-plugin true |
|
Would be nice to have this merged. |
|
@mohd-akram but #3 is already fixed, see the latest "Bump version" commits. |
|
#2 is still an issue however. |
|
@mohd-akram True, but this PR won't fix that. I think they are not publishing the package in the maven repository on purpose for some reason I can't guess. Could be related to the fact that this package is GPG signed by default, and they don't want to release the signed version. Even here I can't tell why this package is GPG signed while the other aren't. I really don't know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
#2 will be resolved after a redeploy from the parent directory. I'm guessing the last deployment was done from the library directory to avoid deploying the sample projects so I added a deploy-plugin skip config to those for future convenience.
I can also confirm that #1 is fixed in the latest version.
mvn clean install -D gpg.skipcompletes successfully with JDK 1.8 on Windows 10.