Skip to content
This repository was archived by the owner on Feb 12, 2022. It is now read-only.

Updates project versions, minor build fixes#4

Open
dannypurcell wants to merge 1 commit intosignalapp:masterfrom
dannypurcell:master
Open

Updates project versions, minor build fixes#4
dannypurcell wants to merge 1 commit intosignalapp:masterfrom
dannypurcell:master

Conversation

@dannypurcell
Copy link
Copy Markdown

Fixes #3

#2 will be resolved after a redeploy from the parent directory. I'm guessing the last deployment was done from the library directory to avoid deploying the sample projects so I added a deploy-plugin skip config to those for future convenience.

Uploading: https://oss.sonatype.org/service/local/staging/deploy/maven2/org/whispersystems/websocket-resources/0.3.3/websocket-resources-0.3.3.jar
Uploading: https://oss.sonatype.org/service/local/staging/deploy/maven2/org/whispersystems/websocket-resources/0.3.3/websocket-resources-0.3.3.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Dropwizard Websocket Resources .................... SUCCESS [0.339s]
[INFO] WebSocket-Resources ............................... FAILURE [10.331s]
[INFO] WebSocket-Resources Sample Server Project ......... SKIPPED
[INFO] WebSocket-Resources Sample Client Project ......... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10.800s
[INFO] Finished at: Sun Jul 24 18:43:16 CDT 2016
[INFO] Final Memory: 38M/981M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.4:deploy (default-deploy) on project websocket-resources: Failed to deploy artifacts: Could not transfer artifact org.whispersystems:websocket-resources:jar:0.3.3 from/to ossrh (https://oss.sonatype.org/service/local/staging/deploy/maven2/): Failed to transfer file: https://oss.sonatype.org/service/local/staging/deploy/maven2/org/whispersystems/websocket-resources/0.3.3/websocket-resources-0.3.3.jar. Return code is: 401, ReasonPhrase:Unauthorized. -> [Help 1]

I can also confirm that #1 is fixed in the latest version. mvn clean install -D gpg.skip completes successfully with JDK 1.8 on Windows 10.

@jnorgan
Copy link
Copy Markdown

jnorgan commented Aug 9, 2016

👍 Can this get merged, please?

@keithyau
Copy link
Copy Markdown

keithyau commented Dec 4, 2016

I require to add GPG skip in order to build success

org.apache.maven.plugins maven-gpg-plugin true

@paride
Copy link
Copy Markdown

paride commented Dec 27, 2016

Another positive feedback: this PR fixes #3 and #2.

@mohd-akram
Copy link
Copy Markdown

Would be nice to have this merged.

@paride
Copy link
Copy Markdown

paride commented Mar 1, 2017

@mohd-akram but #3 is already fixed, see the latest "Bump version" commits.
@moxie0 I think you can close #3 and consequently this PR.

@mohd-akram
Copy link
Copy Markdown

#2 is still an issue however.

@paride
Copy link
Copy Markdown

paride commented Mar 1, 2017

@mohd-akram True, but this PR won't fix that. I think they are not publishing the package in the maven repository on purpose for some reason I can't guess. Could be related to the fact that this package is GPG signed by default, and they don't want to release the signed version. Even here I can't tell why this package is GPG signed while the other aren't. I really don't know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect dependency version WebSocket-Resources/sample-server/pom.xml

5 participants