Gloas vc ptc duty - #8338
Merged
Merged
Conversation
shane-moore
changed the base branch from
gloas-envelope-processing
to
gloas-validator
December 2, 2025 02:13
shane-moore
force-pushed
the
gloas-vc-ptc-duty
branch
from
December 2, 2025 02:35
03fcda9 to
ec2d8aa
Compare
shane-moore
force-pushed
the
gloas-vc-ptc-duty
branch
4 times, most recently
from
December 18, 2025 02:29
807ba02 to
e9a1c2c
Compare
Member
I don't believe this is correct. Have a look at def get_ptc(state: BeaconState, slot: Slot) -> Vector[ValidatorIndex, PTC_SIZE]:
"""
Get the payload timeliness committee for the given ``slot``.
"""
epoch = compute_epoch_at_slot(slot)
seed = hash(get_seed(state, epoch, DOMAIN_PTC_ATTESTER) + uint_to_bytes(slot))
indices: List[ValidatorIndex] = []
# Concatenate all committees for this slot in order
committees_per_slot = get_committee_count_per_slot(state, epoch)
for i in range(committees_per_slot):
committee = get_beacon_committee(state, slot, CommitteeIndex(i))
indices.extend(committee)
return compute_balance_weighted_selection(
state, indices, seed, size=PTC_SIZE, shuffle_indices=False
)The committee selection appears constant for the same seed, and the seed is constant over |
Member
|
ohhh you just mean that you check the cache every slot to ensure we have the same dependent root. |
ethDreamer
reviewed
Jan 6, 2026
eserilev
force-pushed
the
gloas-vc-ptc-duty
branch
from
February 3, 2026 03:07
e9a1c2c to
e490602
Compare
|
Some required checks have failed. Could you please take a look @shane-moore? 🙏 |
pawanjay176
approved these changes
Apr 15, 2026
…oas-vc-ptc-duty
Member
|
@mergify requeue |
Merge Queue Status
Required conditions to enter a queue
|
Merge Queue Status
This pull request spent 29 minutes 45 seconds in the queue, including 28 minutes 8 seconds running CI. Required conditions to merge
|
☑️ This pull request is already queued |
10 tasks
This was referenced Apr 30, 2026
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
How This Works
Implemented in the PR
duties_servicewill now spawn a background polling task for the current and next epoch to check whether any of the registered validators are in a ptc committee. Since re-org is possible, we also poll every slot. The beacon node querying is performed by new request endpointPOST validator/duties/ptc/{epoch}per beacon api spec.To save on bandwidth similar to attestation committee polling, the ptc polling will make a tiny initial requests to learn the
dependent_root, compare with the cacheddependent_root, and only fetch full duties for the epoch if the root has changed (or if the root is unknown like for a new epoch). Old duties are pruned based onHISTORICAL_DUTIES_EPOCHS.Todo
get_ptchelper, but thewarpimplementation still needs to be complete as to send the response to the VC@ethDreamer
@eserilev