Implement gloas stateless block building api - #9568
Conversation
…ateless-block-building-api # Conflicts: # beacon_node/beacon_chain/src/block_production/gloas.rs # beacon_node/http_api/src/beacon/execution_payload_envelopes.rs # beacon_node/http_api/src/produce_block.rs
…ateless-block-building-api
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
Bot
added
waiting-on-author
…ateless-block-building-api
mergify
Bot
added
ready-for-review
|
It seems we might be deprecating the blinded payload stuff here https://github.com/ethereum/beacon-APIs/pull/624/changes |
|
This pull request has merge conflicts. Could you please resolve them @eserilev? 🙏 |
mergify
Bot
added
waiting-on-author
mergify
Bot
added
ready-for-review
|
Hey, I updated #9276 to use the post-beacon-APIs #624 API, including removal of the public blinded-envelope transport. Since there is quite a bit of overlap, it would probably be cleanest to merge #9276 first and then rebase this PR on top, leaving this PR focused on the stateless additions. Just a thought, open to any other approaches. |
|
shoot sorry @shane-moore i didn't see your other PR. yes lets review yours first and get that merged |
|
@eserilev, sg! I just brought the stateful path more aligned to latest beacon api specs yesterday. Tried to avoid it crossing swords with your stateless PR but figured in the end that yours can just inherit the beacon api updates I made 🤙 |
…ateless-block-building-api
|
This pull request has merge conflicts. Could you please resolve them @eserilev? 🙏 |
mergify
Bot
added
waiting-on-author
eserilev
added
ready-for-review
| contents: &SignedExecutionPayloadEnvelopeContents<E>, | ||
| fork_name: ForkName, | ||
| ) -> Result<(), Error> { | ||
| let path = self.post_beacon_execution_payload_envelopes_path(None)?; |
There was a problem hiding this comment.
Should we pass broadcast_validation through here as well, like we do for the stateful helpers above? The query parameter applies to both request forms, and even if gossip is the sensible default here, it seems better for the stateless helpers to be consistent.
jimmygchen
left a comment
jimmygchen
left a comment
There was a problem hiding this comment.
Minor comment above, looks good!
|
Tick the box to add this pull request to the merge queue (same as
|
3 participants
Issue Addressed
#8828
This implements the API but does not change the VC to leverage stateless block production. In a separate PR we should make updates to the VC