Implement Gloas builder state endpoint - #9682
Open
jimmygchen wants to merge 4 commits into
Open
Conversation
chong-he
reviewed
Jul 29, 2026
chong-he
left a comment
chong-he
left a comment
Member
There was a problem hiding this comment.
Looks pretty good, just a comment below not sure if it is intentional or not
chong-he
added
waiting-on-author
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
jimmygchen
added
ready-for-review
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
mergify
Bot
added
waiting-on-author
|
Tick the box to add this pull request to the merge queue (same as
|
mergify
Bot
added
ready-for-review
eserilev
approved these changes
Jul 29, 2026
eserilev
left a comment
eserilev
left a comment
Member
There was a problem hiding this comment.
LGTM
claude says theres maybe a chance to extend test coverage a bit:
- The truly body-less request path is never exercised — the Rust client always serializes at least {}, so json_no_body's empty-bytes branch (the spec's required: false body) has no coverage here. A raw reqwest POST without a body would cover it.
- No status-only filter test (ids: None, statuses: Some([...])) — the code path is symmetric so risk is low, but it's one line to add.
- No malformed-id test (e.g. "0xzz" → 400), which would pin down the deserialize-rejection behavior of deny_unknown_fields + BuilderId parsing.
dont think its super important though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the standard Gloas
POST /eth/v1/beacon/states/{state_id}/buildersendpoint from ethereum/beacon-APIs#614.The endpoint follows the existing validator-state API patterns for state loading, ID and status filtering, response metadata, and error handling. Requests without a body or with empty filters return all builders, while pre-Gloas states return
400.Additional Info
Builder-state requests use the P1 API queue, including requests for
head, because listing the builder registry is not required for validator duties.