Skip to content
This repository was archived by the owner on Jun 25, 2024. It is now read-only.

[WIP] Add verify command and enable use with CI/CD#34

Draft
doodzik wants to merge 82 commits into
sigstore:mainfrom
Shopify:main
Draft

[WIP] Add verify command and enable use with CI/CD#34
doodzik wants to merge 82 commits into
sigstore:mainfrom
Shopify:main

Conversation

@doodzik
Copy link
Copy Markdown

@doodzik doodzik commented Oct 29, 2021

No description provided.

@doodzik doodzik changed the title [WIP] This PR tracks the work on the plugin done at Shopify [WIP] Add verify command Oct 29, 2021
doodzik and others added 21 commits October 28, 2021 22:15
Co-authored-by: Frederik Dudzik <5946811+doodzik@users.noreply.github.com>
super terrible `gem verify` implementation
)

* define CertChain and CertExtensions

* Extract cert code from RekordEntry

* remove method_missing stuff from CertExtensions

* move issuing certificate retrieval into CertExtensions

* move subject_alt_name into CertExtensions
Print all unique emails from valid signature entries
Clean up some of the printed messages
@doodzik doodzik changed the title [WIP] Add verify command [WIP] Add verify command and enable use with CI/CD Nov 18, 2021
@doodzik
Copy link
Copy Markdown
Author

doodzik commented Dec 9, 2021

Will do 👍
There are still some things we want to get done before opening it up for review.

rochlefebvre and others added 28 commits December 15, 2021 10:57
Fix NoMethodError for `gem verify` on an unsigned gem
make verify command work in bundler
Delete the `gem sign` and `gem verify` commands
…gnatures

Rename `install` command's --verify option to --verify-signatures
Rename install command's --verify option to --verify-signatures
Co-authored-by: Jacques Chester <jacques.chester@shopify.com>
When these pre-install hooks are called, Rubygems has already validated
that the given package is a valid gem, both locally and remotely. If the
file does not exist or is not a valid gemfile, no package exists on the
installer at line 32. Plus, Rubygems raises an error.

Co-authored-by: Jacques Chester <jacques.chester@shopify.com>
Ruby 3.1 adds net/smtp to default standard library gems. Since we don't
have a mailer in this project we need to explicitly not include it.

Ref:
https://stackoverflow.com/questions/70500220/rails-7-ruby-3-1-loaderror-cannot-load-such-file-net-smtp
If numbers are not quoted, the YAML parser will treat 3.0 as '3' and so
the latest version minor version of 3, 3.1 will run instead of sticking
with the 3.0.x patch version.

Also adds quotes around the other ruby versions for consistency
Validate file is a gem on signature command
…responses

Check responses from Fulcio/Rekor POSTs, raise unless expected
Store gem signatures in a hashedrekord
@lukehinds
Copy link
Copy Markdown
Member

I guess this is dead now, any more interest in the work @doodzik ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants