ExecuteMsgs Gov Proposal Type - #66
Draft
sunnya97 wants to merge 1 commit into
Draft
Conversation
sunnya97
marked this pull request as draft
February 4, 2021 10:35
| // TallyRoute is the required msgs Signer | ||
| func (emp *ExecuteMsgsProposal) TallyRoute() string { | ||
| msgs := sdk.DecodeMsgs(emp.Messages) | ||
| return sdk.GetSignersMsgs(msgs)[0].String() |
There was a problem hiding this comment.
message signer itself is a tally router?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new governance proposal type that executes Msgs from a specific address. Tries to use the TallyStrategy of the address if registered. Otherwise falls back to the "root" strategy.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes