Fix invalid_data_error! macro to properly format error messages with arguments#84
Merged
Fix invalid_data_error! macro to properly format error messages with arguments#84
invalid_data_error! macro to properly format error messages with arguments#84Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
invalid_data_error!macro was dropping variadic format arguments ($arg), so error messages lost runtime context (for example, values likemethod=0).Changes
InvalidDataerrors directly.stdbuilds to format messages with::alloc::format!($fmt, ...).cfghandling sono_stdbuilds remain compatible withcore2::io::Error::new(which requires&'static strin that mode).invalid_data_errordrops$arg#82 (zlib::tests::issue_82) to ensure formatted values appear in error messages.Closes #82