Fix TypeScript error and extract i18n strings for publication filter#2155
Draft
Copilot wants to merge 2 commits intoclaude/add-publish-in-filter-x8r5Pfrom
Draft
Fix TypeScript error and extract i18n strings for publication filter#2155Copilot wants to merge 2 commits intoclaude/add-publish-in-filter-x8r5Pfrom
Copilot wants to merge 2 commits intoclaude/add-publish-in-filter-x8r5Pfrom
Conversation
- Fix PublicationSelect to use `name` property with writingSystemService - Extract "Any publication" and "Publication" strings to all .po files - Tests passing: CanFilterByPublicationId tests verified Co-authored-by: myieye <12587509+myieye@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Refactor publication filtering to use ILexEntry.PublishIn virtual property
Fix TypeScript error and extract i18n strings for publication filter
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three issues in the publication filter implementation:
TypeScript Error
PublicationSelect.sveltewas accessing non-existentpub.labelpropertywritingSystemService.pickBestAlternative(pub.name, 'analysis')matching pattern inPartOfSpeechSelectandSemanticDomainSelecti18n Strings
Tests
CanFilterByPublicationIdandCanFilterByPublicationId_AndSearchpass💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.