Skip to content

Fix TypeScript error and extract i18n strings for publication filter#2155

Draft
Copilot wants to merge 2 commits intoclaude/add-publish-in-filter-x8r5Pfrom
copilot/sub-pr-2153
Draft

Fix TypeScript error and extract i18n strings for publication filter#2155
Copilot wants to merge 2 commits intoclaude/add-publish-in-filter-x8r5Pfrom
copilot/sub-pr-2153

Conversation

Copy link
Contributor

Copilot AI commented Feb 5, 2026

Fixes three issues in the publication filter implementation:

TypeScript Error

  • PublicationSelect.svelte was accessing non-existent pub.label property
  • Changed to writingSystemService.pickBestAlternative(pub.name, 'analysis') matching pattern in PartOfSpeechSelect and SemanticDomainSelect
- labelSelector={(pub) => pub.label}
+ labelSelector={(pub) => writingSystemService.pickBestAlternative(pub.name, 'analysis')}

i18n Strings

  • Extracted "Any publication" and "Publication" to all 8 .po files
  • Added context comments following existing conventions
  • Non-English translations left empty to fall back to English

Tests

  • Verified CanFilterByPublicationId and CanFilterByPublicationId_AndSearch pass

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

- Fix PublicationSelect to use `name` property with writingSystemService
- Extract "Any publication" and "Publication" strings to all .po files
- Tests passing: CanFilterByPublicationId tests verified

Co-authored-by: myieye <12587509+myieye@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 5, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • ldml.api.sil.org
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/languageforge-lexbox/languageforge-lexbox/backend/FwLite/FwDataMiniLcmBridge.Tests/bin/Debug/net9.0/FwDataMiniLcmBridge.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/languageforge-lexbox/languageforge-lexbox/backend/FwLite/FwDataMiniLcmBridge.Tests/bin/Debug/net9.0/FwDataMiniLcmBridge.Tests.deps.json /home/REDACTED/work/languageforge-lexbox/languageforge-lexbox/backend/FwLite/FwDataMiniLcmBridge.Tests/bin/Debug/net9.0/testhost.dll --port 33631 --endpoint 127.0.0.1:033631 --role client --parentprocessid 4715 --telemetryoptedin false rs/ExampleSentenlog /usr/bin/grep grep (dns block)
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/languageforge-lexbox/languageforge-lexbox/backend/FwLite/FwDataMiniLcmBridge.Tests/bin/Debug/net9.0/FwDataMiniLcmBridge.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/languageforge-lexbox/languageforge-lexbox/backend/FwLite/FwDataMiniLcmBridge.Tests/bin/Debug/net9.0/FwDataMiniLcmBridge.Tests.deps.json /home/REDACTED/work/languageforge-lexbox/languageforge-lexbox/backend/FwLite/FwDataMiniLcmBridge.Tests/bin/Debug/net9.0/testhost.dll --port 43077 --endpoint 127.0.0.1:043077 --role client --parentprocessid 5183 --telemetryoptedin false SyncFixture.cs k/_temp/ghcca-no--noprofile grep (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Refactor publication filtering to use ILexEntry.PublishIn virtual property Fix TypeScript error and extract i18n strings for publication filter Feb 5, 2026
Copilot AI requested a review from myieye February 5, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants