feat: implement macOS connectivity detection#11
Open
polw1 wants to merge 3 commits into
Open
Conversation
Author
|
Creating and destroying an NWPathMonitor on every call feels fragile, especially with a fixed timeout. Apple’s API delivers path updates through callbacks scheduled on a dispatch queue, so treating the first frontend request as a synchronous one-shot query felt like the wrong model. NWPathMonitor is better treated as a long-lived monitor than as a synchronous status getter. So i changed the implementation to create the monitor once, caches the latest status, and returns that cached value from plugin calls. I also start the monitor during plugin setup so the system has a chance to receive the first path update before the frontend makes its first real request, instead of making that request responsible for initializing the monitor. |
velocitysystems
suggested changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds macOS support for
connection_status()using Apple’s Network framework.NWPathMonitornw_path_status_satisfiedasconnected: trueCloses #8
Test plan
cargo checkcargo test --workspace --libnpm run standards