Add a hello endpoint#37
Open
gokhanpicgeta wants to merge 1 commit into
Open
Conversation
# Hello Endpoint Implementation
## Summary
Added a simple HTTP "hello" endpoint to the Silverforge factory project.
## Changes
1. **Created `factory/hello_server.py`**
- New module implementing a basic HTTP server using Python's standard library `http.server`
- Provides a `HelloHandler` class that responds to GET requests on the `/hello` path
- Returns JSON response `{"message": "hello"}` on success, `{"error": "not found"}` on other paths
- `run_server()` function starts the server on configurable host and port
2. **Updated `factory/cli.py`**
- Added new `hello` CLI command to start the HTTP server
- Supports `--port` (default 8000) and `--host` (default 0.0.0.0) options
- Updated docstring to document the new command
- Handles graceful shutdown on Ctrl-C
## Design Decisions
- Used Python's built-in `http.server` module to avoid adding external dependencies
- Simple GET-only endpoint following RESTful conventions
- Returns JSON for consistency with modern APIs
- Endpoint accessible at `/hello` path
- Server runs in foreground (blocks CLI) until interrupted, which is typical for service commands
## Testing
Code passes Python syntax validation. The endpoint can be tested by running:
```bash
factory hello --port 8000
# Then in another terminal:
curl http://localhost:8000/hello
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated implementation by Silverpond Factory (run
600e163c).