Skip to content

FIX Add support for decoration via RequestHandlerMiddlewareAdapter#37

Open
charles-ritchie wants to merge 1 commit into
silverstripe:1from
charles-ritchie:fix/36--route-check-prevents-middleware-decoration
Open

FIX Add support for decoration via RequestHandlerMiddlewareAdapter#37
charles-ritchie wants to merge 1 commit into
silverstripe:1from
charles-ritchie:fix/36--route-check-prevents-middleware-decoration

Conversation

@charles-ritchie
Copy link
Copy Markdown

@charles-ritchie charles-ritchie commented Feb 9, 2021

Fix for #36, seems to work.

There may be some implications of this fix I cannot foresee due to my limited knowledge of SilverStripe GraphQL inner workings.

@michalkleiner michalkleiner changed the title fix: add support for decoration via RequestHandlerMiddlewareAdapter. #36 FIX Add support for decoration via RequestHandlerMiddlewareAdapter Nov 17, 2022
@michalkleiner michalkleiner changed the base branch from master to 1 November 17, 2022 09:34
@michalkleiner
Copy link
Copy Markdown
Contributor

@charles-ritchie what kind of middleware are you applying to this module's controller? Would replacing it using Injector work for you as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants