Skip to content
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions json-java21-jtd/src/main/java/json/java21/jtd/Jtd.java
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,15 @@ void pushChildFrames(Frame frame, java.util.Deque<Frame> stack) {
String discriminatorValueStr = discStr.value();
JtdSchema variantSchema = discSchema.mapping().get(discriminatorValueStr);
if (variantSchema != null) {
// Push variant schema for validation with discriminator key context
Frame variantFrame = new Frame(variantSchema, instance, frame.ptr, frame.crumbs, discSchema.discriminator());
stack.push(variantFrame);
LOG.finer(() -> "Pushed discriminator variant frame for " + discriminatorValueStr + " with discriminator key: " + discSchema.discriminator());
// Special-case: skip pushing variant schema if object contains only discriminator key
if (obj.members().size() == 1 && obj.members().containsKey(discSchema.discriminator())) {
LOG.finer(() -> "Skipping variant schema push for discriminator-only object");
} else {
// Push variant schema for validation with discriminator key context
Frame variantFrame = new Frame(variantSchema, instance, frame.ptr, frame.crumbs, discSchema.discriminator());
stack.push(variantFrame);
LOG.finer(() -> "Pushed discriminator variant frame for " + discriminatorValueStr + " with discriminator key: " + discSchema.discriminator());
}
}
}
}
Expand Down
8 changes: 8 additions & 0 deletions json-java21-jtd/src/main/java/json/java21/jtd/JtdSchema.java
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,14 @@ public Jtd.Result validate(JsonValue instance, boolean verboseErrors) {
return Jtd.Result.failure(error);
}

// Special-case: allow objects with only the discriminator key
// This handles the case where discriminator maps to simple types like "boolean"
// and the object contains only the discriminator field
if (obj.members().size() == 1 && obj.members().containsKey(discriminator)) {
return Jtd.Result.success();
}

// Otherwise, validate against the chosen variant schema
Comment thread
simbo1905 marked this conversation as resolved.
return variantSchema.validate(instance, verboseErrors);
}

Expand Down
46 changes: 46 additions & 0 deletions json-java21-jtd/src/test/java/json/java21/jtd/TestRfc8927.java
Original file line number Diff line number Diff line change
Expand Up @@ -549,4 +549,50 @@ public void testAdditionalPropertiesDefaultsToFalse() throws Exception {
.as("Should have validation error for additional property")
.isNotEmpty();
}

/// Test case from JtdExhaustiveTest property test failure
/// Schema: {"elements":{"properties":{"alpha":{"discriminator":"alpha","mapping":{"type1":{"type":"boolean"}}}}}}
/// Document: [{"alpha":{"alpha":"type1"}},{"alpha":{"alpha":"type1"}}]
/// This should pass validation but currently fails with "expected boolean, got JsonObjectImpl"
@Test
public void testDiscriminatorInElementsSchema() throws Exception {
JsonValue schema = Json.parse("""
{
"elements": {
"properties": {
"alpha": {
"discriminator": "alpha",
"mapping": {
"type1": {"type": "boolean"}
}
}
}
}
}
""");
JsonValue document = Json.parse("""
[
{"alpha": {"alpha": "type1"}},
{"alpha": {"alpha": "type1"}}
]
""");

LOG.info(() -> "Testing discriminator in elements schema - property test failure case");
LOG.fine(() -> "Schema: " + schema);
LOG.fine(() -> "Document: " + document);

Jtd validator = new Jtd();
Jtd.Result result = validator.validate(schema, document);

LOG.fine(() -> "Validation result: " + (result.isValid() ? "VALID" : "INVALID"));
if (!result.isValid()) {
LOG.fine(() -> "Errors: " + result.errors());
}

// This should be valid according to the property test expectation
// but currently fails with "expected boolean, got JsonObjectImpl"
assertThat(result.isValid())
.as("Discriminator in elements schema should validate the property test case")
.isTrue();
}
}
Loading