Make the linux shortcut script show a more specific error message#309
Open
Poikilos wants to merge 3 commits intosimlu:developfrom
Open
Make the linux shortcut script show a more specific error message#309Poikilos wants to merge 3 commits intosimlu:developfrom
Poikilos wants to merge 3 commits intosimlu:developfrom
Conversation
…every error is that java is not installed). Only restart the panel for the running desktop environment. Detect the files in case not running from the static directory (for testing or other scenarios when static's contents aren't in the unzipped release folder from which the script must run).
simlu
reviewed
Jun 14, 2022
Owner
simlu
left a comment
There was a problem hiding this comment.
Hello back and thank you for this!
Left some minor comments, but overall this looks great! Let me know if you want to address these
…stead of overwriting the destination. Check for the destination before creating it. Remove old commented lines. Make the script POSIX compatible (do without bash-specific features). Remove directories showing what is being done, but without redundant output. Do not reload mate-panel--That is usually unnecessary.
Owner
|
Haven't forgotten about this PR. But I do have to fix CI. Will try and schedule some time for it soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I made the original install and uninstall scripts, and this is an improved version with the following changes:
javacommand first and show that specific error instead of running the program.~/var/log/voxelshop/last_run.err) from the output (~/var/log/voxelshop/last_run.log)XDG_SESSION_DESKTOPorXDG_CURRENT_DESKTOPinstead of relying on trial & error withkillall).