Mktmpdir support #48
Closed
Mktmpdir support #48
+281
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djberg96
commented
Oct 4, 2025
.github/workflows/ci.yml
Outdated
| fail-fast: false | ||
| matrix: | ||
| ruby-version: ['3.2', '3.1', '3.0', '2.7', '2.6'] | ||
| ruby-version: ['3.4', '3.3', '3.2', '3.1', '3.0', '2.7'] |
Contributor
Author
There was a problem hiding this comment.
I ended up making a separate PR for this stuff: #49
Owner
|
Hi @djberg96. Thanks for this PR. I have merge the other one, could you rebase this one? I'll review it asap 😊 |
- Moving dev dependencies to Gemfile - Adding binstubs for main binaries - Bumping rake to v13.x - Enabling Ruby warnings during tests - Splitting rubocop and specs in CI - Improving syntax Closes simonc#51.
djberg96
force-pushed
the
mktmpdir_support
branch
2 times, most recently
from
ccad6b1 to
f8122cd
Compare
Owner
|
@djberg96 Sorry I made a few changes on |
Contributor
Author
|
It's fucked, I don't know wtf github is doing. How could there be a diff if I literally copy/pasted the ci.yml file from main? |
Owner
|
@djberg96 Let me know if you just want to push the branch, I can take care of the unfucking 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mktmpdir method along with corresponding tests.
There is also an update to the glob method to support options. Without this change I get:
Addresses #36
Mostly written by Claude 4.5.