Add submenu to select source resolution#59
Add submenu to select source resolution#59gobbledygoober wants to merge 3 commits intosimonguest:mainfrom
Conversation
Resolution submenus could clutter the source picker for users who never need to change resolution. Gate them behind a new Preferences setting so the menu stays clean by default and does not confuse users. - Wire "Preferences..." menu item to the bottom of the source select menu - Resolution submenus are hidden unless enabled in Preferences - Changes take effect immediately without a restart AI-assisted: preference window scaffolding and UserDefaults wiring
gobbledygoober
force-pushed
the
source-resolution-change
branch
from
aa928e2 to
c4e3829
Compare
The existing Preferences… menu item (⌘,) in MainMenu.xib had no action connected. Wire it to openPreferences: on QCAppDelegate so the preferences window can be opened from the standard app menu location without requiring a restart to apply changes. AI-Assisted: XIB action connection wiring for Preferences… menu item
gobbledygoober
force-pushed
the
source-resolution-change
branch
from
c4e3829 to
59159cd
Compare
|
I decided to try to give AI a chance at developing the remaining changes, since I am not familiar with Swift. After a few tries, it worked. I understand that people have different sensitivities to this, so I added a disclaimer in the commit message details ("AI-assisted ...") to make it clear. Commit 5da4889 adds a preference pane to hide or show the new resolution menu. By default the menu is hidden: But will show once the option is enabled: However, after re-reading the original request, I realized that the intended location of the preference pane was probably the conventional location in the main Quick Camera menu, and not the Source Select menu. Commit 59159cd addresses this: 
According to our future robot overlords, the code changes are also compatible with OSX 10.7 and later, which satisfies the original request to support OSX 10.15+ for the existing user base. However, I have not verified that claim, because I do not have a suitable test environment. It works fine on macOS 26.3 so far. I realize that it has been over a year since the last commits to this project, but I think this is ready for review if you are interested. Thanks for reading! |
1 participant
This is a simple rebase of the @beazlr02's work on #14 onto the latest main branch. I am a new macOS user and was looking for this exact resolution change functionality in a no-nonsense application, and Quick Camera fit the bill!
I am not a Swift developer and have not made an attempt at the changes suggested by @simonguest on that PR, and have also only lightly tested the new feature. The path of the file involved with the original branch changed, so a bit of work was needed to apply the patch to the updated path.
So even if this PR is closed, hopefully the existence of the updated branch will make the new feature more accessible to others.
Thanks for reading.