#15 added basic tsconfig extends support by bennobuilder · Pull Request #16 · simonhaenisch/rollup-plugin-typescript-paths

bennobuilder · 2023-07-14T05:09:09Z

Note: Sry for the wrong formatting.. maybe add normal eslint & prettier config with .prettierrc and .eslintrc :)

…imonhaenisch/rollup-plugin-typescript-paths#16

simonhaenisch · 2023-07-17T13:22:02Z

There's a normal prettier config in the package.json which is officially supported by Prettier 🤓 (first option in the list here)

I don't think I added linting to this project 😅

simonhaenisch · 2023-07-17T13:25:15Z

index.ts

-		},
-	};
+  const { compilerOptions } = getTsConfig(tsConfigPath);
+  const outDir = compilerOptions.outDir ?? '.';


This was pointed out here already: #14 (comment)

Right in my case, outDir was always the default (".") since I've defined it in my compilerOptions -> never was read in.

Since the resolvedFileName is already an absolute path, joining (with path.join()) it with the default outDir (".") resulted in the correct absolute path, as resolvedFileName seems already correct?

Example resolvedFileName: "C:/path/to/my/monorepo/packages/dtif-to-svg/src/d3.ts"

However, now that it reads in the outDir correctly due to your suggested getParsedCommandLineOfConfigFile() method that works like a charm, the outDir is something like "C:/path/to/my/monorepo/packages/dtif-to-svg/dist" which I defined in the compilerOptions of my tsconfig.json. However, now path.join() will join these both absolute paths that result in: "C:/path/to/my/monorepo/packages\dtif-to-svg\dist\C:/path/to/my/monorepo/packages\dtif-to-svg\src\d3.ts". And thats not correct.

-> For me it works best without any defined outDir as resolvedFileName already points to the correct location
-> Do we actually need to define the outDir and when might it be required, because for me it isn't?

In the same issue comments I think further down there's a solution with using path.relative instead of path.join.

yeah I tested that but the resulting relative path was something like ../src/path/to/file and since the script was executed in the root of the package it navigated out of the package and tried to find the src/path/to/file.ts there..

but anyway if the MR doesn't fit the project's philosophy that's ok too :) I've implemented your very useful plugin in my scripts and updated it to my project's needs (represented in this MR).. but I've not tested it in other environments and everyone has different requirements and expectations, which is of course hard to cover in a single project.. cheers :)

simonhaenisch · 2023-07-17T13:28:08Z

index.ts

+    // Try to resolve as a file relative to the current config
+    extendedConfigPath = path.join(
+      path.dirname(rootConfigPath),
+      config.extends


extends can actually be an array since TS 5.0. I'm pretty sure there's probably a better method from the TypeScript API to retrieve the tsconfig.

I wrote this a long time ago when I was still completely unfamiliar with the API 😅

https://stackoverflow.com/a/70013087/2897426 maybe this is the correct solution

that actually worked quite good :)

bennobuilder · 2023-07-18T03:55:59Z

There's a normal prettier config in the package.json which is officially supported by Prettier 🤓 (first option in the list here)

I don't think I added linting to this project 😅

thanks for pointing that out.. did totally miss that 😅 prettier is good enough, just forgot that it can be configured in package.json :)

… command and improve ts config read in

simonhaenisch · 2023-07-20T09:29:36Z

index.ts


-			const targetFileName = join(
-				outDir,
+			// TODO: Do we need outDir as "resolvedFileName" is already correct absolute path


I think resolvedFileName is only the correct absolute path with Rollup 3 but not Rollup 2 or so.

simonhaenisch · 2023-07-20T09:31:41Z

index.ts

-	if (!configJson) {
-		return defaults;
+	// Read in tsconfig.json
+	const parsedCommandLine = ts.getParsedCommandLineOfConfigFile(


This might be a lot slower than what happened before, so probably it makes sense to memoize the getTsConfig function for performance. I can add this (hopefully i'll find some time to properly go through this PR in the next few weeks).

simonhaenisch · 2023-07-20T09:33:20Z

index.ts

+type TsConfig = {
 	outDir: string;
-}
+} & Omit<ts.CompilerOptions, 'outDir'>;


Shouldn't it be like

Suggested change

} & Omit<ts.CompilerOptions, 'outDir'>;

} & { compilerOptions: Omit<ts.CompilerOptions, 'outDir'> };

Anyway, I thought having outDir next to compilerOptions in the tsconfig was wrong in the first place?

mdorda · 2023-12-12T09:58:36Z

Any progress with merging? Still an issue :-/

simonhaenisch#15 added basic tsconfig extends support

108a0ef

bennobuilder mentioned this pull request Jul 14, 2023

Support for extends Property in tsconfig.json #15

Open

bennobuilder added a commit to dyn-art/monorepo-v1 that referenced this pull request Jul 14, 2023

#30 added rollup-plugin-typescript-paths manually until MR is merged: s…

8716974

…imonhaenisch/rollup-plugin-typescript-paths#16

simonhaenisch reviewed Jul 17, 2023

View reviewed changes

bennobuilder added 2 commits July 18, 2023 07:29

simonhaenisch#15 fixed formatting and added shx for cross platform rm…

0c31350

… command and improve ts config read in

simonhaenisch#15 removed pnpm-lock again oops

2eb3a43

simonhaenisch reviewed Jul 20, 2023

View reviewed changes

	} & Omit<ts.CompilerOptions, 'outDir'>;
	} & { compilerOptions: Omit<ts.CompilerOptions, 'outDir'> };

Conversation

bennobuilder commented Jul 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simonhaenisch commented Jul 17, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bennobuilder Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bennobuilder Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bennobuilder commented Jul 18, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdorda commented Dec 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bennobuilder commented Jul 14, 2023 •

edited

Loading

bennobuilder Jul 18, 2023 •

edited

Loading

bennobuilder Jul 18, 2023 •

edited

Loading