Skip to content

Finessing DPI division #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dh219 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Finessing DPI division #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae61141
Merge pull request #1 from simoninns/master
dh219 Apr 26, 2021
f1bdace
This proposed change stops the inverse mouse acceleration effect unde…
dh219 Apr 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions SmallyMouse2/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,8 @@ void processMouse(void)
uint8_t processMouseMovement(int8_t movementUnits, uint8_t axis, bool limitRate, bool dpiDivide)
{
uint16_t timerTopValue = 0;
static int8_t skippedunits[2] = {0,0};


// Set the mouse movement direction and record the movement units
if (movementUnits > 0) {
Expand All @@ -455,7 +457,19 @@ uint8_t processMouseMovement(int8_t movementUnits, uint8_t axis, bool limitRate,
// Apply DPI limiting if required
if (dpiDivide) {
movementUnits /= DPI_DIVIDER;
if (movementUnits < 1) movementUnits = 1;
// avoid inverse mouse acceleration effect where slow movement is at full DPI -- dh219
if( movementUnits == 0 ) {// has been scaled away to zero
if( skippedunits[axis] >= DPI_DIVIDER ) {
movementUnits = 1;
skippedunits[axis] = 0;
}
else {
if( skippedunits[axis] < 0 ) {
skippedunits[axis] = 0;
}
skippedunits[axis]++;
}
}
}

// Add the movement units to the quadrature output buffer
Expand All @@ -467,7 +481,19 @@ uint8_t processMouseMovement(int8_t movementUnits, uint8_t axis, bool limitRate,
// Apply DPI limiting if required
if (dpiDivide) {
movementUnits /= DPI_DIVIDER;
if (movementUnits > -1) movementUnits = -1;
// avoid inverse mouse acceleration effect where slow movement is at full DPI -- dh219
if( movementUnits == 0 ) {// has been scaled away to zero
if( skippedunits[axis] <= -DPI_DIVIDER ) {
movementUnits = -1;
skippedunits[axis] = 0;
}
else {
if( skippedunits[axis] > 0 ) {
skippedunits[axis] = 0;
}
skippedunits[axis]--;
}
}
}

// Add the movement units to the quadrature output buffer
Expand Down