Some minor software tweaks that might be useful#39
Open
drdpj wants to merge 4 commits intosimoninns:mainfrom
Open
Some minor software tweaks that might be useful#39drdpj wants to merge 4 commits intosimoninns:mainfrom
drdpj wants to merge 4 commits intosimoninns:mainfrom
Conversation
… connectors from amazon. Fixed bug in robot build stl build script.
…fully - not enough info recorded at the moment, that needs work 2) penup-pendown travel 45 degrees, not 90. It's very hard to set the cam on the servo properly so you get the pen properly up, and then don't grind it when down if at 90 degrees. If up is the servo at 90 (assuming "up" has the cam set at a nice 45 degree angle to the horizontal) then everything works nicely.
Owner
|
It's kinda tough to pull apart pull requests like this... The best thing to do (imho) is to use branches. Since you don't have too many changes you could - back up your repo as-is... refork the original... make 2 branches... apply the STL changes in one branch and the firmware in the other... pull request on the firmware branch. Different branches are a good way to deal with these sorts of things I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore all the scad stuff - I can't work out how to omit that, but some small changes to the python, particularly I think the penup/pendown positions need 45 degrees of travel. 90 makes no sense as it just risks grinding the servo arm into the base which kippered my servo.