Restructure ORM: normalize Manifest / ManifestEntry / Archive#7
Open
iparask wants to merge 2 commits into
Open
Restructure ORM: normalize Manifest / ManifestEntry / Archive#7iparask wants to merge 2 commits into
iparask wants to merge 2 commits into
Conversation
Assisted by Claude Sonnet 5 and Opus 4.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the single
ArchiveQueuetable (which pickled the whole manifest into aPickleTypecolumn) with three real tables —Manifest,ManifestEntry, andArchive(renamed fromArchiveQueue) — wired by real foreign keys with cascade deletes and a 1:1Manifest↔Archivelink. The in-memory DTO formerly namedArchiveis renamedArchiveJobto free up the name. Schema style follows the sibling Librarian codebase (db.namespace, column docstrings, lockeddequeueviawith_for_update(skip_locked=True)filteringboth
consumedandcompleted).The consumers are cut over to the new shape: the
/archiveroute builds aManifestviaget_or_createplusManifestEntryrows and oneArchivejob in a single commit, and the worker rebuilds the manifest dict fromitem.manifest.entries(eager-loaded) instead of unpickling a blob, snapshotsarchive_root/archive_pathper row, and takes asession_makerparameter while returningbool— two seams that let a future task-based runner drop in. Alembic is introduced with a single baseline revision stamping the three tables;create_all()is retained for the test suite.🤖 Assisted by Claude Sonnet 5 and Opus 4.8