Open
Conversation
Contributor
Author
|
@xzackli , these changes possibly affect some of your case-of-use. Can you review them and, in case you agree, fix the ACT tests accordingly? |
Contributor
Author
|
I think this PR should be closed. @xzackli , as I said in my last comment, I believe it would be better if you could give it a look before we merge: some of your tests/applications may be affected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that the following
evalfunction forPowerSpectrumFromFilehas two bugsfgspectra/fgspectra/power.py
Line 84 in 9d9fe8e
ell = ell_0for unclear reasonsell_0 == None, the unintended result is the addition of an extra axis to the template Cl (in addition to the axis added at the previous point)I propose to remove
ell_0and use theampargument