Conversation
This is the last commit before Python 3.8 support was dropped. It's the version that socs defines in [1], and what ultimately gets used by the pysmurf-controller agent. [1] - https://github.com/simonsobs/socs/blob/331d46e5e764b53203d20785c48918b335aba47d/requirements.txt#L48
This is a dependency here, but in our current builds is defined over in socs [1]. It really belongs here, where the direct import occurs. [1] - https://github.com/simonsobs/socs/blob/331d46e5e764b53203d20785c48918b335aba47d/requirements.txt#L45
These couple of dependencies were missing from our requirements file, and I suspect are rarely actually used/get installed somewhere else in the chain if they really are needed, but we should define them here.
msilvafe
approved these changes
Feb 10, 2026
tristpinsm
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing dependencies to our
pyproject.tomlandrequirements.txtfiles. This is related to the packaging work I've been doing in #493, #494, and #497.The main focus here is
sotodlibandpysmurf. These are currently defined insocs, and get installed for use by the pysmurf-controller agent there. However, these packages aren't imported anywhere insocs, they're really dependencies ofsodetliband so should be defined as dependencies here, not insocs.traitletsandpytestwere also missing, so I added those while I was reviewing imports.EDIT: I left off
pyepicsbecause of its impending removal in #485.