Conversation
msilvafe
approved these changes
Jul 3, 2026
msilvafe
left a comment
Contributor
There was a problem hiding this comment.
Thanks for correcting and simplifying. I didn't realize we were doing something non-standard!
Just one inline comment about docstrings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docstring says we apodize by cosine taper but I have realized that it has not been standard one.
I'm not sure if it's okay to change the default, but this PR changes the default to standard cosine taper (hann window).
The calculation of weight_for_signal for hwpss and azss were redundant as get_apodize_window_from_flags.
They are simplified.