Add other_fields to loader#1694
Open
ykyohei wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation is to load preprocess archive per observation easily.
The problem was preprocess archive is usually computed per (band, wafer) and each has scalar fields that cannot be concatenated.
One solution was to drop them by
drop_fields, but number of fields to drop is large for ISO preprocess archive and it can increase.This PR adds
other_fieldsof aman.concatenate to loader to 'drop' them all at once or pick 'first'.sotodlib/sotodlib/core/axisman.py
Lines 508 to 516 in 88a3230