Skip to content

Skip single-process flag on macOS to prevent Chromium crashes #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flgusto wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip single-process flag on macOS to prevent Chromium crashes #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
"os/signal"
"path/filepath"
"strconv"
"runtime"
"strings"
"syscall"
"time"
Expand Down Expand Up @@ -377,11 +378,16 @@ func cmdStart(args []string) {
l := launcher.New().
Set("no-sandbox").
Set("disable-gpu").
Set("single-process"). // Required for screenshots in gVisor/container environments
Leakless(false). // Keep Chrome alive after CLI exits
UserDataDir(dataDir).
Headless(headless)

// single-process is required for screenshots in gVisor/container environments
// but crashes Chromium on complex sites on macOS
if runtime.GOOS != "darwin" {
l = l.Set("single-process")
}

// When in non-headless mode, make sure that we show the startup window immediately
// (instead of showing a window only after calling "rodney open")
if !headless {
Expand Down