Reduce CSP inline style violations in drug stock webviews#5786
Merged
Reduce CSP inline style violations in drug stock webviews#5786
Conversation
Co-authored-by: Igbanam <igbanam@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story card: SIMPLEBACK-95
Because
style-src-attrandstyle-src-elemCSP violations are among the highest-volume Sentry errors for Simple Server, with a large concentration on the webview drug stock pages.This addresses
inline_stylesheetinline_jsstyle="..."attributes from the highest-traffic webview templates:app/views/webview/drug_stocks/new.html.erbapp/views/webview/drug_stocks/index.html.erbwebview/drug_stocks/new.styleattributes from SVG assets used on that flow:app/assets/images/chevron-left.svgapp/assets/images/check-mark-small.svgTest instructions
/webview/drug_stocks/new/webview/drug_stocksstyle="..."attributes on the modified elements.<style>/<script>tags include anonceattribute.SIMPLE-SERVER-1RQandSIMPLE-SERVER-1RRafter deploy for a drop in new events.