[FEAT]: Implement stream and media handling methods#110
Open
Doominika wants to merge 30 commits intofeat/implement-base-streamApifrom
Open
[FEAT]: Implement stream and media handling methods#110Doominika wants to merge 30 commits intofeat/implement-base-streamApifrom
Doominika wants to merge 30 commits intofeat/implement-base-streamApifrom
Conversation
djenczewski
requested changes
Nov 28, 2025
| @@ -0,0 +1,8 @@ | |||
| package com.simplito.java.privmx_endpoint.model.streams; | |||
|
|
|||
| public abstract class Frame { | |||
Member
There was a problem hiding this comment.
this class is probably unnecessary, because its not used anywhere
|
|
||
| @FunctionalInterface | ||
| public interface OnFrameCallback { | ||
| void run(long a, long b, Frame c, String d); |
| package com.simplito.java.privmx_endpoint.model.streams; | ||
|
|
||
| public class RemoteStreamId { | ||
| private final Long value; |
| this.value = value; | ||
| } | ||
|
|
||
| public Long getValue() { |
| package com.simplito.java.privmx_endpoint.model.streams; | ||
|
|
||
| public class StreamHandle { | ||
| private final Long value; |
| ) { | ||
| JniContextUtils ctx(env); | ||
| if (ctx.nullCheck(stream_handle, "Stream Handle") || | ||
| ctx.nullCheck(track, "Media Device")) { |
Member
There was a problem hiding this comment.
this should be parameter name
| jobject thiz, | ||
| jobject stream_handle | ||
| ) { | ||
| JniContextUtils ctx(env); |
| privmx::endpoint::stream::StreamSettings result; | ||
| JniContextUtils ctx(env); | ||
| jclass cls = ctx->GetObjectClass(streamSettings); | ||
| StreamSettingsJNI streamSettingsJni (env, streamSettings); |
Member
There was a problem hiding this comment.
this will cause memory leak
| "com/simplito/java/privmx_endpoint/model/streams/DeviceType"); | ||
|
|
||
| jmethodID valuesMID = ctx->GetStaticMethodID(itemCls, "values", | ||
| "()[Lcom/simplito/java/privmx_endpoint/model/streams/DeviceType;"); |
Member
There was a problem hiding this comment.
Suggested change
| "()[Lcom/simplito/java/privmx_endpoint/model/streams/DeviceType;"); | |
| "()Lcom/simplito/java/privmx_endpoint/model/streams/DeviceType;" |
| ctx->NewStringUTF(mediaDevice_c.name.c_str()), | ||
| ctx->NewStringUTF(mediaDevice_c.id.c_str()), | ||
| deviceType2Java(ctx, mediaDevice_c.type) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.