Update SCC permissions for simplyblock deployment#133
Closed
tylergmuir wants to merge 1 commit into
Closed
Conversation
Added commands to grant SCC permissions for specific service accounts instead of the all service accounts group.
Collaborator
|
Hey @tylergmuir! Thanks for the PR! I just wonder if it was closed because it didn't work afterwards or is there another reason like contributing issues? |
Author
|
It only partially worked. For a fully functional config you have to make a similar permission change twice and it depends on if you are deploying the CSI only or the full operator. I plan to open a replacement PR once I've done more testing as it will require some references to OpenShift specific config in a couple of places. |
Collaborator
|
Awesome! Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added commands to grant SCC permissions for specific service accounts instead of the all service accounts group.
This is to ensure only the additional permissions are granted to SimplyBlock and not all service accounts in the OpenShift cluster.