Skip to content

Add non-blocking storage-node migration with promote and worker-list reconcile #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noctarius wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add non-blocking storage-node migration with promote and worker-list reconcile #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7a0fb1
Add non-blocking storage-node migration with promote and worker-list …
noctarius Jul 14, 2026
7c72424
Fix operator lint: extract success-message const, split restart phase…
noctarius Jul 14, 2026
113de34
Address Copilot review: fail persistence, promote deadline, docs, mig…
noctarius Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions helm-charts/charts/simplyblock-operator/crds/storage.simplyblock.io_storageclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,14 +374,19 @@ spec:
state:
type: string
subPhase:
description: SubPhase tracks the active drain step within the
remove action.
description: |-
SubPhase tracks the active step within a multi-phase action: the drain steps
for remove, and the non-blocking restart/migration steps
(Migrating -> Promoting -> ReconcilingWorkers). Migrating is shared between the
two flows and disambiguated by Action.
enum:
- Validating
- Suspending
- Migrating
- Verifying
- Removing
- Promoting
- ReconcilingWorkers
type: string
triggered:
description: Triggered indicates whether the underlying backend
Expand Down
20 changes: 18 additions & 2 deletions helm-charts/charts/simplyblock-operator/crds/storage.simplyblock.io_storagenodesets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,17 @@ spec:
x-kubernetes-validations:
- message: field is immutable
rule: self == oldSelf
newSsdPcie:
description: |-
NewSsdPcie is an action-scoped parameter: it applies ONLY to the node named by nodeUUID
during the current restart action, exactly like workerNode and reattachVolume. It is not
per-set device configuration. It lists additional NVMe PCIe addresses to bind on the
target host and is passed through to the control-plane restart as new_ssd_pcie. Use it when
migrating to a host whose data drives sit at different PCIe addresses than the origin host.
Note: the backend appends these to the node's existing device list rather than replacing it.
items:
type: string
type: array
nodeFailureDomains:
additionalProperties:
format: int32
Expand Down Expand Up @@ -443,14 +454,19 @@ spec:
state:
type: string
subPhase:
description: SubPhase tracks the active drain step within the
remove action.
description: |-
SubPhase tracks the active step within a multi-phase action: the drain steps
for remove, and the non-blocking restart/migration steps
(Migrating -> Promoting -> ReconcilingWorkers). Migrating is shared between the
two flows and disambiguated by Action.
enum:
- Validating
- Suspending
- Migrating
- Verifying
- Removing
- Promoting
- ReconcilingWorkers
type: string
triggered:
description: Triggered indicates whether the underlying backend
Expand Down
15 changes: 13 additions & 2 deletions operator/api/v1alpha1/storagenodeset_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,14 @@ type StorageNodeSetSpec struct {
// +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Reattach Volume"
// ReattachVolume reattaches volumes during restart where supported by the backend.
ReattachVolume *bool `json:"reattachVolume,omitempty"`
// +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="New SSD PCIe"
// NewSsdPcie is an action-scoped parameter: it applies ONLY to the node named by nodeUUID
// during the current restart action, exactly like workerNode and reattachVolume. It is not
// per-set device configuration. It lists additional NVMe PCIe addresses to bind on the
// target host and is passed through to the control-plane restart as new_ssd_pcie. Use it when
// migrating to a host whose data drives sit at different PCIe addresses than the origin host.
// Note: the backend appends these to the node's existing device list rather than replacing it.
NewSsdPcie []string `json:"newSsdPcie,omitempty"`
// +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="OpenShift Cluster"
// OpenShiftCluster indicates OpenShift-specific behavior should be enabled.
OpenShiftCluster *bool `json:"openShiftCluster,omitempty"`
Expand Down Expand Up @@ -313,8 +321,11 @@ type ActionStatus struct {
ObservedGeneration int64 `json:"observedGeneration,omitempty"`
// Triggered indicates whether the underlying backend action has been fired.
Triggered bool `json:"triggered,omitempty"`
// SubPhase tracks the active drain step within the remove action.
// +kubebuilder:validation:Enum=Validating;Suspending;Migrating;Verifying;Removing
// SubPhase tracks the active step within a multi-phase action: the drain steps
// for remove, and the non-blocking restart/migration steps
// (Migrating -> Promoting -> ReconcilingWorkers). Migrating is shared between the
// two flows and disambiguated by Action.
// +kubebuilder:validation:Enum=Validating;Suspending;Migrating;Verifying;Removing;Promoting;ReconcilingWorkers
// +optional
SubPhase string `json:"subPhase,omitempty"`
// VolumesMigrated is the count of volumes successfully migrated so far.
Expand Down
5 changes: 5 additions & 0 deletions operator/api/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions operator/config/crd/bases/storage.simplyblock.io_storageclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,14 +374,19 @@ spec:
state:
type: string
subPhase:
description: SubPhase tracks the active drain step within the
remove action.
description: |-
SubPhase tracks the active step within a multi-phase action: the drain steps
for remove, and the non-blocking restart/migration steps
(Migrating -> Promoting -> ReconcilingWorkers). Migrating is shared between the
two flows and disambiguated by Action.
enum:
- Validating
- Suspending
- Migrating
- Verifying
- Removing
- Promoting
- ReconcilingWorkers
type: string
triggered:
description: Triggered indicates whether the underlying backend
Expand Down
20 changes: 18 additions & 2 deletions operator/config/crd/bases/storage.simplyblock.io_storagenodesets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,17 @@ spec:
x-kubernetes-validations:
- message: field is immutable
rule: self == oldSelf
newSsdPcie:
description: |-
NewSsdPcie is an action-scoped parameter: it applies ONLY to the node named by nodeUUID
during the current restart action, exactly like workerNode and reattachVolume. It is not
per-set device configuration. It lists additional NVMe PCIe addresses to bind on the
target host and is passed through to the control-plane restart as new_ssd_pcie. Use it when
migrating to a host whose data drives sit at different PCIe addresses than the origin host.
Note: the backend appends these to the node's existing device list rather than replacing it.
items:
type: string
type: array
nodeFailureDomains:
additionalProperties:
format: int32
Expand Down Expand Up @@ -443,14 +454,19 @@ spec:
state:
type: string
subPhase:
description: SubPhase tracks the active drain step within the
remove action.
description: |-
SubPhase tracks the active step within a multi-phase action: the drain steps
for remove, and the non-blocking restart/migration steps
(Migrating -> Promoting -> ReconcilingWorkers). Migrating is shared between the
two flows and disambiguated by Action.
enum:
- Validating
- Suspending
- Migrating
- Verifying
- Removing
- Promoting
- ReconcilingWorkers
type: string
triggered:
description: Triggered indicates whether the underlying backend
Expand Down
29 changes: 25 additions & 4 deletions operator/dist/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1588,14 +1588,19 @@ spec:
state:
type: string
subPhase:
description: SubPhase tracks the active drain step within the
remove action.
description: |-
SubPhase tracks the active step within a multi-phase action: the drain steps
for remove, and the non-blocking restart/migration steps
(Migrating -> Promoting -> ReconcilingWorkers). Migrating is shared between the
two flows and disambiguated by Action.
enum:
- Validating
- Suspending
- Migrating
- Verifying
- Removing
- Promoting
- ReconcilingWorkers
type: string
triggered:
description: Triggered indicates whether the underlying backend
Expand Down Expand Up @@ -2015,6 +2020,17 @@ spec:
x-kubernetes-validations:
- message: field is immutable
rule: self == oldSelf
newSsdPcie:
description: |-
NewSsdPcie is an action-scoped parameter: it applies ONLY to the node named by nodeUUID
during the current restart action, exactly like workerNode and reattachVolume. It is not
per-set device configuration. It lists additional NVMe PCIe addresses to bind on the
target host and is passed through to the control-plane restart as new_ssd_pcie. Use it when
migrating to a host whose data drives sit at different PCIe addresses than the origin host.
Note: the backend appends these to the node's existing device list rather than replacing it.
items:
type: string
type: array
nodeFailureDomains:
additionalProperties:
format: int32
Expand Down Expand Up @@ -2199,14 +2215,19 @@ spec:
state:
type: string
subPhase:
description: SubPhase tracks the active drain step within the
remove action.
description: |-
SubPhase tracks the active step within a multi-phase action: the drain steps
for remove, and the non-blocking restart/migration steps
(Migrating -> Promoting -> ReconcilingWorkers). Migrating is shared between the
two flows and disambiguated by Action.
enum:
- Validating
- Suspending
- Migrating
- Verifying
- Removing
- Promoting
- ReconcilingWorkers
type: string
triggered:
description: Triggered indicates whether the underlying backend
Expand Down
Loading
Loading