Commit 3cecc86
committed
refactor(resources): correct the row-cache premise and clear an R1b false positive
Two things the migration notes got wrong, now fixed in the places that assert them.
The playbook claimed an open table and an embedded one "should hit one cache
entry, and forking that doubles every fetch". Half right, and the wrong half was
driving a planned change. The SCHEMA is keyed on the table id alone, so it
genuinely is one entry on every surface. ROWS are not, and should not be:
`pageSize` is in the key, the page pulls 1000-row pages so `ensureAllRowsLoaded`
can drain for select-all/export in few round trips, and a panel wants a fast
first screen and never drains. One number would either make a chat panel fetch
1000 rows to show ten, or make every bulk operation ten times the requests. The
divergence is correct; both the hook and the playbook now say so.
`MiniTablePanel` -> `LandingLeadsPanel`. It is hardcoded landing-hero markup
with no queries and no relationship to the table resource, so a `Mini` +
resource-noun name misread as a per-consumer fork of the real view — to a reader
and to the audit. R1b baseline drops 12 -> 11.
The R1b note itself was also wrong, claiming every `Embedded*` drops off as its
kind gets a canonical view. The `*Actions` members are tab chrome, not views:
`EmbeddedFileActions` and `EmbeddedInterfaceActions` outlived their migrations,
and `EmbeddedTableActions` just outlived table's. Only the content components go.1 parent 37519d4 commit 3cecc86
4 files changed
Lines changed: 41 additions & 19 deletions
File tree
- apps/sim
- app/(landing)/components/landing-preview/components/landing-preview-home
- components/resources
- table-view/hooks
- scripts
Lines changed: 8 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
254 | 254 | | |
255 | 255 | | |
256 | 256 | | |
257 | | - | |
| 257 | + | |
258 | 258 | | |
259 | 259 | | |
260 | 260 | | |
| |||
382 | 382 | | |
383 | 383 | | |
384 | 384 | | |
385 | | - | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
386 | 391 | | |
387 | | - | |
| 392 | + | |
388 | 393 | | |
389 | 394 | | |
390 | 395 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
147 | 152 | | |
148 | 153 | | |
149 | 154 | | |
| |||
Lines changed: 12 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
25 | 31 | | |
26 | 32 | | |
27 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
86 | 92 | | |
87 | | - | |
| 93 | + | |
88 | 94 | | |
89 | 95 | | |
90 | 96 | | |
| |||
0 commit comments