fix(emcn/header): icon consistency — breadcrumb menus, Connections, FolderCode by waleedlatif1 · Pull Request #6263 · simstudioai/sim

waleedlatif1 · 2026-08-04T20:11:25Z

Some resource-header breadcrumb dropdowns rendered icons next to their labels and some rendered bare text. The split turned out to be perfectly systematic:

Resource crumb menus — all had icons

Site	Items
`tables/[tableId]/table.tsx:1097`	Rename · Lock settings · Delete
`knowledge/[id]/base.tsx:892`	Rename · Tags · Delete
`knowledge/[id]/[documentId]/document.tsx:541`	Rename · Tags · Delete
`files/files.tsx:1260`	Download · Rename · Share · Delete

Folder crumb menus — none had icons

Site	Items
`files/files.tsx:1794`	Rename
`tables/tables.tsx:463`	Rename · Delete
`knowledge/knowledge.tsx:923`	Rename · Delete

Both menus open from adjacent segments of the same breadcrumb, so the inconsistency was visible side by side. This adds Pencil/Trash to the three folder-crumb menus, reusing the exact icons their resource-crumb counterparts already use.

DropdownOption.icon was already optional and already rendered by resource-header.tsx:332 — no component change needed.

Swept for stragglers

A repo-wide scan for { label, onClick } options without an icon in any file building dropdownItems/currentFolderActions now returns zero. Three initial hits were false positives, left as-is:

table.tsx:1165 and files.tsx:1127 — toast actions (toast.error(..., { action })), not menu items.
files.tsx:1244 — the root "Files" crumb itself, which takes its glyph from the header's crumb.icon ?? Icon fallback.

Checks

biome clean · type-check --force 23/23 (0 cached)

Also in this PR: `Connections` redrawn on the house geometry

Connections was a filled glyph in a tight 0 0 13 13 box with a 0.2 hairline stroke. Measured at size-[14px]:

icon	glyph	stroke
`library`	9.3px	0.90px
`globe`	8.1px	0.90px
`database`	9.2px	0.90px
`pencil`	10.8px	0.90px
`connections` (before)	21.5px	0.22px
`connections` (after)	10.9px	0.90px

It sits in RESOURCE_REGISTRY beside Library, Globe and Database and renders through the same renderTabIcon(className), so it read as a different weight class in a single row.

Redrawn as a stroke outline on the 24-box at 1.55, preserving the topology: a 2×2 grid with a circle top-right, linked left-to-right along the top, down the right column, and left-to-right along the bottom. Verified by rendering old and new side by side against their registry neighbours at both 14px and 96px before committing.

Call-site safety

The intrinsic size changes 13×13 → 24×24, so every render path was checked — all pass an explicit square size:

resource-tabs.tsx:242 → size-[14px]
recently-deleted.tsx → ICON_CLASS = size-5 shrink-0
add-resource-dropdown.tsx:492,669,677 → size-[14px]

biome clean · type-check --force 23/23 (0 cached)

Also in this PR: `FolderCode` — rescued from #6262

#6262 was merged at its first commit (86532fed9) while GitHub was still showing the PR as one commit, so its second commit — the FolderCode geometry fix — never shipped. folder.tsx is on staging; folder-code.tsx was left as the original.

That commit is cherry-picked here (99b3f626b). Its body path is byte-identical to the Folder body that merged in #6262.

FolderCode carried the same fill-based construction Folder did — 0 0 15 13 with a 0.3 hairline stroke. At size-[14px] it rendered a 19.9px glyph at 0.28px stroke where a standard icon renders ~10.5px at 0.90px. Now 10.1px / 0.90px, matching folder and folder-open.

Call sites (agent-group.tsx, FeaturePlatformPanel, agent-code-graphic.tsx, playground) all pass an explicit square size-*, so the intrinsic 15×13 → 24×24 change is absorbed.

Rebased onto current staging (which now carries the merged Folder fix). biome clean · type-check --force 23/23 (0 cached).

vercel · 2026-08-04T20:11:30Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docs	Ready	Preview	Aug 4, 2026 8:42pm

cursor · 2026-08-04T20:11:38Z

PR Summary

Low Risk
Visual and menu-label consistency only; no auth, data, or API behavior changes. Icon intrinsic size changes are absorbed at call sites that already set explicit square dimensions.

Overview
Aligns folder breadcrumb dropdowns with resource crumb menus by adding Pencil and Trash icons to Rename/Delete in Files, Knowledge, and Tables list views. DropdownOption.icon was already supported in the header renderer—no component change.

Connections is redrawn from a filled 13×13 glyph to the shared 24-box stroke style (1.55 weight, round caps/joins), preserving the four-node lattice topology so it matches Library, Globe, and Database in the resource registry.

FolderCode is updated to share Folder’s body path and the same stroke geometry (cherry-picked geometry that did not ship in a prior merge), so the folder icon family reads at one visual weight at typical size-* classes.

^{Reviewed by Cursor Bugbot for commit 99b3f62. Configure here.}

greptile-apps · 2026-08-04T20:13:38Z

Greptile Summary

The PR standardizes breadcrumb action menus by adding icons to folder actions and redraws Connections and FolderCode on the shared 24-unit outline geometry.

Adds Pencil and Trash icons to folder breadcrumb menus for files, knowledge, and tables.
Redraws Connections while preserving its four-node topology.
Aligns FolderCode geometry and stroke weight with the Folder icon family.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/files/files.tsx	Adds the established Pencil component to the folder breadcrumb Rename action.
apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx	Adds established Pencil and Trash components to folder breadcrumb actions using the existing dropdown contract.
apps/sim/app/workspace/[workspaceId]/tables/tables.tsx	Adds Pencil and Trash icons to folder actions without changing permissions or action behavior.
packages/emcn/src/icons/connections.tsx	Replaces the filled Connections glyph with bounded stroke geometry whose known callers provide explicit sizing.
packages/emcn/src/icons/folder-code.tsx	Aligns FolderCode with the Folder outline geometry; known callers provide explicit square sizing.

_{Reviews (3): Last reviewed commit: "fix(emcn): match FolderCode geometry to ..." | Re-trigger Greptile}

waleedlatif1 · 2026-08-04T20:31:17Z

@greptile

waleedlatif1 · 2026-08-04T20:31:18Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 6d971d5. Configure here.}

The resource crumb's menu (table, knowledge base, document, file) rendered Rename/Tags/Share/Download/Delete with icons, but the folder crumb's menu rendered bare labels. The two open from adjacent segments of the same breadcrumb, so the inconsistency was visible side by side. Add the matching icons to the three folder-crumb menus.

Connections was a filled glyph in a tight 0 0 13 13 box with a 0.2 hairline stroke. At size-[14px] it rendered a 21.5px glyph at 0.22px stroke where its neighbours render ~10.5px at 0.90px, so it read as a different weight class in the resource registry it shares with Library, Globe and Database. Redraw as a stroke outline on the 24-box at 1.55, preserving the topology: a 2x2 grid with a circle top-right, linked along the top, down the right column, and along the bottom. Now 10.9px at 0.90px.

FolderCode carried the same fill-based construction Folder did: a tight 0 0 15 13 box with a 0.3 hairline stroke. At size-[14px] it rendered a 19.9px glyph at 0.28px stroke where a standard icon renders ~10.5px at 0.90px — roughly twice the size at a third the weight. It renders in Chat's TOOL_ICONS map for glob/mv/mkdir, directly beside Search, File and Database, so the mismatch was visible in a single list. Reuse Folder's body path verbatim and inset code brackets centred on the body, so the whole folder family shares one silhouette and one weight.

waleedlatif1 · 2026-08-04T20:38:41Z

@greptile

waleedlatif1 · 2026-08-04T20:38:42Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 99b3f62. Configure here.}

vercel Bot temporarily deployed to Preview August 4, 2026 20:11 Inactive

cursor Bot reviewed Aug 4, 2026

View reviewed changes

vercel Bot deployed to Preview August 4, 2026 20:36 View deployment

waleedlatif1 added 3 commits August 4, 2026 13:37

waleedlatif1 force-pushed the fix/breadcrumb-menu-icon-parity branch from 6d971d5 to 99b3f62 Compare August 4, 2026 20:38

waleedlatif1 changed the title ~~fix(header): give every breadcrumb menu item an icon~~ fix(emcn/header): icon consistency — breadcrumb menus, Connections, FolderCode Aug 4, 2026

waleedlatif1 merged commit f0e57cb into staging Aug 4, 2026
23 of 26 checks passed

waleedlatif1 deleted the fix/breadcrumb-menu-icon-parity branch August 4, 2026 20:41

cursor Bot reviewed Aug 4, 2026

View reviewed changes

vercel Bot deployed to Preview August 4, 2026 20:42 View deployment

waleedlatif1 mentioned this pull request Aug 4, 2026

v0.7.56: ui improvements, docs update, emcn consolidation #6269

Open

Navigation Menu

Uh oh!

fix(emcn/header): icon consistency — breadcrumb menus, Connections, FolderCode - #6263

fix(emcn/header): icon consistency — breadcrumb menus, Connections, FolderCode#6263
waleedlatif1 merged 3 commits into
stagingfrom
fix/breadcrumb-menu-icon-parity

waleedlatif1 commented Aug 4, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Aug 4, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Aug 4, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Aug 4, 2026 •

edited

Loading

Important Files Changed

Uh oh!

waleedlatif1 commented Aug 4, 2026

Uh oh!

waleedlatif1 commented Aug 4, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

waleedlatif1 commented Aug 4, 2026

Uh oh!

waleedlatif1 commented Aug 4, 2026

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

waleedlatif1 commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swept for stragglers

Checks

Also in this PR: Connections redrawn on the house geometry

Call-site safety

Also in this PR: FolderCode — rescued from #6262

Uh oh!

vercel Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

waleedlatif1 commented Aug 4, 2026

Uh oh!

waleedlatif1 commented Aug 4, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Aug 4, 2026

Uh oh!

waleedlatif1 commented Aug 4, 2026

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Aug 4, 2026 •

edited

Loading

Also in this PR: `Connections` redrawn on the house geometry

Also in this PR: `FolderCode` — rescued from #6262

vercel Bot commented Aug 4, 2026 •

edited

Loading

cursor Bot commented Aug 4, 2026 •

edited

Loading

greptile-apps Bot commented Aug 4, 2026 •

edited

Loading