chore(scripts): drop the script unit tests and the exports that served them - #6343
chore(scripts): drop the script unit tests and the exports that served them#6343waleedlatif1 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview
Reviewed by Cursor Bugbot for commit dcecd26. Configure here. |
|
Folding this into #6340 instead — that PR already owns the |
Greptile SummaryThis PR removes the standalone unit suites for two repository policy scripts, removes the boundary suite from its package gate, and makes the helpers private.
Confidence Score: 4/5The PR appears safe to merge, but it removes the only focused regression coverage for two policy-enforcement scripts. Both production gates remain executable and the removed exports have no consumers, while the accepted concerns are non-blocking losses of behavioral test coverage rather than current functional failures. Files Needing Attention: package.json, scripts/check-tool-request-boundary.test.ts, scripts/check-migrations-safety.test.ts
|
| Filename | Overview |
|---|---|
| package.json | Removes the boundary scanner’s unit-test phase while preserving its standalone production scan. |
| scripts/check-tool-request-boundary.test.ts | Deletes the only controlled coverage for prohibited and permitted tool-request access patterns. |
| scripts/check-tool-request-boundary.ts | Makes the scanner helper private; no remaining external consumers were found. |
| scripts/check-migrations-safety.test.ts | Deletes broad coverage of migration classifications, annotations, and SQL parser edge cases without replacement. |
| scripts/check-migrations-safety.ts | Makes lintSql private while leaving the production migration check behavior intact. |
Comments Outside Diff (1)
-
scripts/check-migrations-safety.test.tsMigration linter coverage removed
Deleting this suite removes the only controlled coverage for destructive-operation classifications, safety annotations, and SQL parser edge cases. Since the remaining gate exercises
lintSqlonly on changed migrations, a later parser or rule regression can go unnoticed until it incorrectly accepts or rejects a real migration.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Reviews (1): Last reviewed commit: "chore(scripts): drop the script unit tes..." | Re-trigger Greptile
| "check:api-validation:strict": "bun run scripts/check-api-validation-contracts.ts --check --enforce-boundary-baseline", | ||
| "check:realtime-prune": "bun run scripts/check-realtime-prune-graph.ts", | ||
| "check:tool-request-boundary": "bun test scripts/check-tool-request-boundary.test.ts && bun run scripts/check-tool-request-boundary.ts", | ||
| "check:tool-request-boundary": "bun run scripts/check-tool-request-boundary.ts", |
There was a problem hiding this comment.
Boundary scanner coverage removed
The gate now scans only the current production tree, so it no longer exercises controlled cases for direct, computed, optional, aliased, and destructured request access. A later scanner regression can therefore leave CI green while missing prohibited access or rejecting valid request objects.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
scripts/check-migrations-safety.test.tsandscripts/check-tool-request-boundary.test.tsbun test …half of thecheck:tool-request-boundarygate inpackage.json(it invoked a file this PR removes, so CI would fail otherwise).check:migrationsnever referenced its testlintSqlandfindToolRequestBoundaryViolations— both had zero references outside their own script and existed only so the tests could reach them. They stay in place as internal functionsThe sibling removal for
check-sql-date-bindingrides on #6340, which owns that file. Differentpackage.jsonline, so the two do not conflict.Verification
Both gates still run and still pass on their own:
No YAML, JSON, or script reference to either deleted file remains.
Type of Change
Testing
Ran both check gates directly; biome clean on all three changed files.
Checklist