Skip to content

fix(scripts): make the specifier audit path-separator agnostic #6355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Aug 7, 2026
Merged

fix(scripts): make the specifier audit path-separator agnostic #6355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions scripts/check-import-specifiers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
* Usage: `bun run scripts/check-import-specifiers.ts [--verbose]`
*/
import { readdirSync, readFileSync, statSync } from 'node:fs'
import { dirname, join, relative, resolve } from 'node:path'
import { dirname, join, relative, resolve, sep } from 'node:path'
import { fileURLToPath } from 'node:url'

const SCRIPT_DIR = dirname(fileURLToPath(import.meta.url))
Expand Down Expand Up @@ -46,11 +46,16 @@ const REQUIRE_RE = /\brequire\s*\(\s*['"]([^'"]+)['"]\s*\)/g
*/
const SUBPATH_REQUIRED = new Set(['@sim/utils'])

/** Repo-relative path, always `/`-separated — `relative()` yields `\` on Windows. */
function repoPath(absolute: string): string {
return relative(ROOT, absolute).replaceAll('\\', '/')
}

/** Only source a bundler compiles — see the "Deliberately NOT checked" note above. */
function isCompiledSource(full: string, name: string): boolean {
if (!/\.(ts|tsx)$/.test(name) || name.endsWith('.d.ts')) return false
if (/\.(test|spec)\.tsx?$/.test(name)) return false
const rel = relative(ROOT, full)
const rel = repoPath(full)
return !rel.startsWith('apps/sim/scripts/') && !rel.startsWith('apps/realtime/scripts/')
}

Expand Down Expand Up @@ -78,7 +83,7 @@ function walk(dir: string, acc: string[] = []): string[] {
* would otherwise make every specifier in the repo look generated.
*/
function isGeneratedPath(absolute: string): boolean {
const rel = relative(ROOT, absolute)
const rel = repoPath(absolute)
if (rel.startsWith('..')) return true
return rel.split('/').some((segment) => segment.startsWith('.') || SKIP_DIRS.has(segment))
}
Expand Down Expand Up @@ -160,7 +165,7 @@ for (const group of ['apps', 'packages']) {
workspaces.sort((a, b) => b.dir.length - a.dir.length)

function workspaceFor(file: string): Workspace | undefined {
return workspaces.find((w) => file.startsWith(`${w.dir}/`))
return workspaces.find((w) => file.startsWith(w.dir + sep))
}

/** Matched a tsconfig path, but every target is generated — distinct from missing (`null`). */
Expand Down Expand Up @@ -328,7 +333,7 @@ for (const file of files) {
checked++
if (!outcome.ok) {
violations.push({
file: relative(ROOT, file),
file: repoPath(file),
line: lineAt(at),
specifier: spec,
kind: 'unresolved',
Expand All @@ -340,7 +345,7 @@ for (const file of files) {
const subs = packageExports(spec)
const example = subs ? [...subs.keys()].find((k) => k !== '.') : undefined
violations.push({
file: relative(ROOT, file),
file: repoPath(file),
line: lineAt(at),
specifier: spec,
kind: 'bare-barrel',
Expand Down
Loading