Allow application to be eager loaded without ActionCable#201
Open
adamsosterics wants to merge 1 commit intosimukappu:masterfrom
Open
Allow application to be eager loaded without ActionCable#201adamsosterics wants to merge 1 commit intosimukappu:masterfrom
adamsosterics wants to merge 1 commit intosimukappu:masterfrom
Conversation
When Zeitwerk loads these files it expects classes defined in them even if ActionCable is not used.
Author
|
I'm not 100% sure if this is the best solution but these modifications allowed me to load the gem. |
Author
|
I tried to write a test which eager loads the gem with and without ActionCable included, but it didn't really work out. But then I needed a way to initialize the app with and without ActionCable, but as you load the app in the spec_helper, I'm not sure hot to do it properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #200
Summary
The files in
app/channels/activity_notificationtriggered Zeitwerk errors when the app didn't use ActionCable.This PR changes these files, so the classes are always defined, no matter if ActioneCable is defined or not.
Other Information