fix(upload from-google-photos): add --include-failed-videos flag#1305
Open
fermino wants to merge 1 commit intosimulot:mainfrom
Open
fix(upload from-google-photos): add --include-failed-videos flag#1305fermino wants to merge 1 commit intosimulot:mainfrom
fermino wants to merge 1 commit intosimulot:mainfrom
Conversation
fermino
force-pushed
the
main
branch
2 times, most recently
from
70518be to
7b59513
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some scenarios a user may want to try uploading videos that have been marked by Google Photos as failed, as mentioned in #1242.
This PR adds a flag
--include-failed-videosthat excludes the path check.I still think the path check can be improved by only checking the path component instead of the whole thing, but this is just the flag addition.