Skip to content

Feature/buffer from stream#6

Open
fantkolja wants to merge 3 commits intodevelopfrom
feature/buffer-from-stream
Open

Feature/buffer from stream#6
fantkolja wants to merge 3 commits intodevelopfrom
feature/buffer-from-stream

Conversation

@fantkolja
Copy link
Collaborator

sinahwz and others added 3 commits October 5, 2020 11:14
* Feature/zipper stream arguments (#4)

* update(zipper): extend sonfig

* update(zipper): extend sonfig

* update(zipper): handle glob

* update(zipper): handle glob

* update(zipper): handle streams

* Update: updates

Co-authored-by: Mykola Fant <Mykola.Fant@infopulse.com>
Co-authored-by: Sina Hwz <sina.howaizi@gmail.com>

* Update: version1.0.6 now

Co-authored-by: Mykola Fant <fantkolja@mail.ru>
Co-authored-by: Mykola Fant <Mykola.Fant@infopulse.com>
@fantkolja fantkolja requested a review from sinahwz October 6, 2020 21:02
@sinahwz
Copy link
Owner

sinahwz commented Oct 9, 2020

@fantkolja I am thinking, we could add another option in zipper as well -> { outputBuffer: true } and use the other method inside zipper to return buffer in one shot.

And maybe one single option: { output: 'buffer' | 'stream' } which defaults to the old zipPath if not provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants