feat (samples/webhooks): Report 'webhooks' server template from quickstart repository by JPPortier · Pull Request #302 · sinch/sinch-sdk-java

JPPortier · 2026-02-02T17:00:26Z

No description provided.

…start repository

github-actions · 2026-02-02T17:00:40Z

Dependency Review

✅ No vulnerabilities or license issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA bebc511.

Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Manifest Files

examples/webhooks/pom.xml

com.diffplug.spotless:spotless-maven-plugin@2.40.0
com.sinch.sdk:sinch-sdk-java@>= 1.0.0
org.springframework.boot:spring-boot-maven-plugin@
org.springframework.boot:spring-boot-starter@
org.springframework.boot:spring-boot-starter-web@

examples/webhooks/README.md

examples/webhooks/src/main/java/com/mycompany/app/mailgun/Controller.java

examples/webhooks/src/main/java/com/mycompany/app/mailgun/ServerBusinessLogic.java

asein-sinch · 2026-02-02T20:32:34Z

examples/webhooks/src/main/java/com/mycompany/app/sms/Controller.java

+      value = "/SmsEvent",
+      consumes = MediaType.APPLICATION_JSON_VALUE,
+      produces = MediaType.APPLICATION_JSON_VALUE)
+  public ResponseEntity<Void> smsDeliveryEvent(


Nit: events are not about delivery reports only.

asein-sinch · 2026-02-02T20:34:18Z

examples/webhooks/src/main/java/com/mycompany/app/sms/ServerBusinessLogic.java

+  public void processInboundEvent(InboundMessage event) {
+    trace(event);
+  }


As you are splitting the inbounds and the delivery reports, do you think it makes sense to also showcase the different kinds of inbounds and delivery reports?

Not sure, I could have think to reduce snippet to simple "SmsEvent"

The current trace will display the type of event (because of part of the toString from classes)

asein-sinch · 2026-02-02T20:47:02Z

examples/webhooks/src/main/java/com/mycompany/app/voice/Controller.java

+
+    LOGGER.finest("JSON response: " + serializedResponse);
+
+    return ResponseEntity.ok().body(serializedResponse);


Same question for DICE, PIE and notification events: does it make sense to return "null" in the 200 OK JSON response body?

Right.

Replaced with empty bodies too.

asein-sinch · 2026-02-02T20:47:59Z

examples/webhooks/src/main/java/com/mycompany/app/voice/ServerBusinessLogic.java

+
+    LOGGER.info("Handle event :" + event);
+
+    return SvamlControl.builder().build();


Is there a place where you showcase the construction of a SVAML response (action + multiple instructions)?

No, not within this skeleton (this is not the purpose of this skeleton)

But when getting-started and tutorials will be migrated here: yes:

https://github.com/sinch/sinch-sdk-java-quickstart/blob/main/getting-started/voice/respond-to-incoming-call/server/src/main/java/com/mycompany/app/voice/ServerBusinessLogic.java

https://github.com/sinch/sinch-sdk-java-quickstart/blob/main/tutorials/voice/capture-leads-app/src/main/java/com/mycompany/app/voice/ServerBusinessLogic.java

asein-sinch · 2026-02-02T20:52:22Z

examples/webhooks/src/main/resources/application.yaml

+  application-api-key:
+  application-api-secret:


Nit: referred as application key and application secret in the documentation

Snippets are also based onto "xxx-api-xxx"; if going to this direction will be part of dedicated ticket

asein-sinch · 2026-02-02T20:55:23Z

examples/webhooks/README.md

@@ -0,0 +1,79 @@
+# Backend application built using Sinch Java SDK to handle incoming webhooks
+
+This directory contains a server application based onto [Sinch SDK java](https://github.com/sinch/sinch-sdk-java)


English: don't use onto but on:

Suggested change

This directory contains a server application based onto [Sinch SDK java](https://github.com/sinch/sinch-sdk-java)

This directory contains a server application based on the [Sinch SDK java](https://github.com/sinch/sinch-sdk-java)

Onto implies movement toward a surface or position, this is not the case here

asein-sinch · 2026-02-02T20:56:41Z

examples/webhooks/README.md

+- `project-id`: YOUR_project_id
+- `key-id`: YOUR_access_key_id
+- `key-secret`: YOUR_access_key_secret


For most of the use cases, they are not needed

Yes but here we are delivering a general purpose skeleton

Added a dedicated comment for this section to help users/AIs to consume it properly

examples/webhooks/src/main/java/com/mycompany/app/mailgun/Controller.java

examples/webhooks/src/main/java/com/mycompany/app/numbers/Controller.java

feat (samples/webhooks): Report 'webhooks' server template from quick…

d4947e7

…start repository

JPPortier requested review from asein-sinch, matsk-sinch and rpredescu-sinch as code owners February 2, 2026 17:00

matsk-sinch reviewed Feb 2, 2026

View reviewed changes

examples/webhooks/README.md Show resolved Hide resolved

examples/webhooks/README.md Outdated Show resolved Hide resolved

asein-sinch reviewed Feb 2, 2026

View reviewed changes

rpredescu-sinch reviewed Feb 3, 2026

View reviewed changes

examples/webhooks/src/main/java/com/mycompany/app/mailgun/Controller.java Outdated Show resolved Hide resolved

examples/webhooks/src/main/java/com/mycompany/app/numbers/Controller.java Show resolved Hide resolved

PR's comment

e411d7d

JPPortier requested review from asein-sinch, matsk-sinch and rpredescu-sinch February 4, 2026 10:25

JPPortier added 2 commits February 4, 2026 12:06

fix link

56c837e

enhance comment

bebc511

rpredescu-sinch approved these changes Feb 4, 2026

View reviewed changes


		LOGGER.finest("JSON response: " + serializedResponse);

		return ResponseEntity.ok().body(serializedResponse);


		LOGGER.info("Handle event :" + event);

		return SvamlControl.builder().build();

		@@ -0,0 +1,79 @@
		# Backend application built using Sinch Java SDK to handle incoming webhooks

		This directory contains a server application based onto [Sinch SDK java](https://github.com/sinch/sinch-sdk-java)

Conversation

JPPortier commented Feb 2, 2026

Uh oh!

github-actions bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency Review

Snapshot Warnings

Scanned Manifest Files

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JPPortier Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Feb 2, 2026 •

edited

Loading

JPPortier Feb 4, 2026 •

edited

Loading