Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for FunkeyOS as a new output format for artwork. FunkeyOS stores artwork images directly alongside the ROM files (same directory, same filename with .png extension), unlike formats such as MinUI or Anbernic that use dedicated sub-folders.
Changes:
- New
src/format/funkey.tsmodule implementing theOutputFormatinterface for FunkeyOS. Format.Funkeyenum value added and its case handled ingetOutputFormatinformat.ts.- CLI help text updated to list
funkeyas a valid output format option.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/format/funkey.ts |
New format module implementing artwork export/cleanup for FunkeyOS |
src/format/format.ts |
Adds Funkey enum value and dynamic import case for the new format |
src/cli.ts |
Updates the --output option description to include funkey |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (artTypes.art2 && (art1Url ?? art2Url)) { | ||
| debug(`Found art URL(s): "${art1Url}" / "${art2Url}"`); | ||
| await composeImageTo(art1Url, art2Url, artPath, { width: options.width, height: options.height }); | ||
| } else if art1Url) { |
There was a problem hiding this comment.
There is a syntax error on this line: the opening parenthesis ( is missing before art1Url. The condition should be else if (art1Url) to match the syntax used in the equivalent code in anbernic.ts and minui.ts. As written, this file will fail to compile/parse entirely.
| } else if art1Url) { | |
| } else if (art1Url) { |
|
@sam1am your last force push contains a malicious script for blockchain, you should check your computer if that was not voluntary |
No description provided.