SAC-28858 meta data changes#134
Open
narenderqlik wants to merge 4 commits intoSAC-27501-upgrade-api-version-to-v2from
Open
SAC-28858 meta data changes#134narenderqlik wants to merge 4 commits intoSAC-27501-upgrade-api-version-to-v2from
narenderqlik wants to merge 4 commits intoSAC-27501-upgrade-api-version-to-v2from
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds parent stream metadata tracking to the Mambu tap by introducing parent-child relationships between streams and updating metadata generation to include parent stream identification.
- Added
parentfield to child stream configurations (cardsandloan_repayments) - Updated metadata generation logic to include parent-tap-stream-id when parent streams exist
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
RushiT0122
requested changes
Oct 15, 2025
| 'key_properties': ['encoded_key'], | ||
| 'replication_method': 'FULL_TABLE' | ||
| 'replication_method': 'FULL_TABLE', | ||
| 'parent': 'loans' |
Contributor
There was a problem hiding this comment.
Suggested change
| 'parent': 'loans' | |
| 'parent': 'loan_accounts' |
| 'key_properties': ['deposit_id', 'reference_token'], | ||
| 'replication_method': 'FULL_TABLE' | ||
| 'replication_method': 'FULL_TABLE', | ||
| 'parent': 'deposits' |
Contributor
There was a problem hiding this comment.
Suggested change
| 'parent': 'deposits' | |
| 'parent': 'deposit_accounts' |
RushiT0122
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
This PR adds parent stream metadata tracking to the Pepperjam tap by introducing a new
parent_streamfield to stream configurations and updating metadata generation to include parent-tap-stream-id information.Ticket : SAC-28871
parent_streamfield to stream configurations in the flattened streams structureChanges
Manual QA steps
You need to comment out the authentication (auth) part in a discovery function, and then generate a log file to verify the changes.
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code