Skip to content

SAC-28858 meta data changes#134

Open
narenderqlik wants to merge 4 commits intoSAC-27501-upgrade-api-version-to-v2from
SAC-28858-add-new-metadata
Open

SAC-28858 meta data changes#134
narenderqlik wants to merge 4 commits intoSAC-27501-upgrade-api-version-to-v2from
SAC-28858-add-new-metadata

Conversation

@narenderqlik
Copy link
Copy Markdown

@narenderqlik narenderqlik commented Oct 13, 2025

Description of change

This PR adds parent stream metadata tracking to the Pepperjam tap by introducing a new parent_stream field to stream configurations and updating metadata generation to include parent-tap-stream-id information.

Ticket : SAC-28871

  • Added parent_stream field to stream configurations in the flattened streams structure
  • Updated metadata generation to include parent-tap-stream-id when a parent stream exists

Changes

File Description
tap_mambu/helpers/schema.py Added parent_stream field to both parent and child stream configurations
tap_mambu/helpers/schema.py Updated metadata generation to include parent-tap-stream-id for child streams

Manual QA steps

You need to comment out the authentication (auth) part in a discovery function, and then generate a log file to verify the changes.

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@narenderqlik narenderqlik requested a review from Copilot October 13, 2025 04:40
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds parent stream metadata tracking to the Mambu tap by introducing parent-child relationships between streams and updating metadata generation to include parent stream identification.

  • Added parent field to child stream configurations (cards and loan_repayments)
  • Updated metadata generation logic to include parent-tap-stream-id when parent streams exist

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Copy Markdown
Contributor

@RushiT0122 RushiT0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the requested changes as well as add metadata validation in integration tests.

Comment thread tap_mambu/helpers/schema.py Outdated
'key_properties': ['encoded_key'],
'replication_method': 'FULL_TABLE'
'replication_method': 'FULL_TABLE',
'parent': 'loans'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'parent': 'loans'
'parent': 'loan_accounts'

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are made

Comment thread tap_mambu/helpers/schema.py Outdated
'key_properties': ['deposit_id', 'reference_token'],
'replication_method': 'FULL_TABLE'
'replication_method': 'FULL_TABLE',
'parent': 'deposits'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'parent': 'deposits'
'parent': 'deposit_accounts'

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants