Skip to content

Feature/Implementation of OAuth Authorization option to generate bearer token#54

Open
f-ocal wants to merge 7 commits intosinger-io:masterfrom
Woopra:feature/bearer_token
Open

Feature/Implementation of OAuth Authorization option to generate bearer token#54
f-ocal wants to merge 7 commits intosinger-io:masterfrom
Woopra:feature/bearer_token

Conversation

@f-ocal
Copy link
Copy Markdown

@f-ocal f-ocal commented May 10, 2019

No description provided.

@cmerrick
Copy link
Copy Markdown
Contributor

Hi @f-ocal, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Copy Markdown
Contributor

You did it @f-ocal!

Thank you for signing the Singer Contribution License Agreement.

Copy link
Copy Markdown

@luandy64 luandy64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f-ocal Just a few minor things and I'd be happy to merge this 👍

Comment thread tap_pipedrive/tap.py Outdated
Comment thread tap_pipedrive/tap.py Outdated
Comment thread tap_pipedrive/tap.py Outdated
@luandy64
Copy link
Copy Markdown

@f-ocal I lied, I think there's more work to be done here. Something like this PR is going to have to be implemented. If we only add your PR, then cli.py will throw an error because the OAuth flow doesn't need an API token.

Is this a change you are comfortable making?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants